REVIEW comments, #32

js/common-vsm/model/VSMModel.ts

@@ -42,6 +42,8 @@ export type VSMModelOptions<T extends VSMField> = SelfOptions & StrictOmit<PDLMo
 
 export default class VSMModel<T extends VSMField> extends PDLModel<T> {
 
+  //REVIEW Declarations of BooleanProperty should be Property<boolean>
+
   // Static tool visibility
   public readonly isLaunchAngleVisibleProperty: BooleanProperty;
   public readonly isLaunchSpeedVisibleProperty: BooleanProperty;

js/common-vsm/view/InteractiveToolPanel.ts

@@ -36,7 +36,7 @@ export type InteractiveToolPanelOptions = SelfOptions & WithRequired<PDLPanelOpt
 export default class InteractiveToolPanel extends PDLPanel {
 
   public constructor(
-    isMeasuringTapeVisibleProperty: BooleanProperty,
+    isMeasuringTapeVisibleProperty: BooleanProperty, //REVIEW should be Property<boolean>
     isStopwatchVisibleProperty: PhetioProperty<boolean>,
     providedOptions: InteractiveToolPanelOptions ) {
 

js/common/model/Field.ts

@@ -86,7 +86,7 @@ export default abstract class Field extends PhetioObject {
   public readonly launchHeightProperty: TReadOnlyProperty<number>;
 
   // True if the continuous mode is set to launching or false if not launching
-  public readonly isContinuousLaunchingProperty: BooleanProperty;
+  public readonly isContinuousLaunchingProperty: BooleanProperty; //REVIEW should be Property<boolean>
 
   // An array of projectiles that are currently in the air. Note: No projectile should be in the airborneProjectiles and landedProjectiles array simultaneously.
   public readonly airborneProjectiles: Projectile[] = [];

js/common/model/PDLEventTimer.ts

@@ -21,7 +21,7 @@ export default class PDLEventTimer {
   private readonly period: number;
 
   // Whether the timer is running
-  private readonly isRunningProperty: BooleanProperty;
+  private readonly isRunningProperty: BooleanProperty; //REVIEW should be Property<boolean>
 
   // Remaining time until the next event, in seconds
   private readonly timeRemainingProperty: NumberProperty;

js/common/model/PDLModel.ts

@@ -63,7 +63,7 @@ export default abstract class PDLModel<T extends Field> implements TModel {
   public readonly singleOrContinuousProperty: Property<SingleOrContinuous>;
 
   // Setting for whether the user wants to see the paths of the projectiles
-  public readonly isPathsVisibleProperty: BooleanProperty;
+  public readonly isPathsVisibleProperty: BooleanProperty; //REVIEW should be Property<boolean>
 
   // Abstract Property that indicates the selected Launcher
   public readonly abstract launcherProperty: TReadOnlyProperty<Launcher>;

js/measures/model/MeasuresModel.ts

@@ -44,6 +44,8 @@ export default class MeasuresModel extends SMModel<MeasuresField> {
   // Whether the launcher is custom or mystery
   public readonly mysteryOrCustomProperty: DynamicProperty<MysteryOrCustom, MysteryOrCustom, MeasuresField>;
 
+  //REVIEW Declarations of BooleanProperty should be Property<boolean>
+
   // Whether the mean is visible on the field and histogram
   public readonly isMeanVisibleProperty: BooleanProperty;
 

js/measures/view/DataMeasuresOverlay.ts

@@ -52,6 +52,7 @@ export default class DataMeasuresOverlay extends Node {
   public constructor( modelViewTransform: ModelViewTransform2 | ChartTransform,
                       meanDistanceProperty: PhetioProperty<number | null>,
                       standardDeviationDistanceProperty: PhetioProperty<number | null>,
+                      //REVIEW next 3 params of type BooleanProperty should be TReadOnlyProperty<boolean>
                       isMeanDisplayedProperty: BooleanProperty,
                       isStandardDeviationDisplayedProperty: BooleanProperty,
                       isValuesDisplayedProperty: BooleanProperty,

js/measures/view/MeasuresHistogramNode.ts

@@ -42,6 +42,7 @@ export default class MeasuresHistogramNode extends VSMHistogramNode {
                       numberOfLandedProjectilesProperty: TReadOnlyProperty<number>,
                       histogram: Histogram,
                       horizontalAxisLabelText: TReadOnlyProperty<string>,
+                      //REVIEW next 3 params of type BooleanProperty should be TReadOnlyProperty<boolean>
                       isMeanVisibleProperty: BooleanProperty,
                       isStandardDeviationVisibleProperty: BooleanProperty,
                       isValuesVisibleProperty: BooleanProperty,

js/measures/view/MeasuresInteractiveToolPanel.ts

@@ -26,9 +26,9 @@ type MeasuresInteractiveToolPanelOptions = SelfOptions & InteractiveToolPanelOpt
 
 export default class MeasuresInteractiveToolPanel extends InteractiveToolPanel {
   public constructor(
-    isMeasuringTapeVisibleProperty: BooleanProperty,
+    isMeasuringTapeVisibleProperty: BooleanProperty, //REVIEW should be Property<boolean>
     isStopwatchVisibleProperty: PhetioProperty<boolean>,
-    isIntervalToolVisibleProperty: BooleanProperty,
+    isIntervalToolVisibleProperty: BooleanProperty, //REVIEW should be Property<boolean>
     providedOptions: MeasuresInteractiveToolPanelOptions ) {
 
     class IntervalToolIcon extends Node {