REVIEW comments, #32

js/common-vsm/model/VSMModel.ts

@@ -185,12 +185,14 @@ export default class VSMModel<T extends VSMField> extends PDLModel<T> {
 
     const measuringTapeTandem = providedOptions.tandem.createTandem( 'measuringTape' );
 
+    //README Why is this not Vector2Property?
     this.measuringTapeBasePositionProperty = new Property<Vector2>( new Vector2( 0, 0 ), {
       tandem: measuringTapeTandem.createTandem( 'basePositionProperty' ),
       phetioValueType: Vector2.Vector2IO,
       phetioReadOnly: true
     } );
 
+    //README Why is this not Vector2Property?
     this.measuringTapeTipPositionProperty = new Property<Vector2>( new Vector2( 50, 0 ), {
       tandem: measuringTapeTandem.createTandem( 'tipPositionProperty' ),
       phetioValueType: Vector2.Vector2IO,

js/common/model/Field.ts

@@ -173,6 +173,8 @@ export default abstract class Field extends PhetioObject {
     } : { validValues: [ 'angle45' ] } as const;
 
     const initialAngle = options.isLauncherConfigurationPhetioInstrumented ? 'angle30' : 'angle45';
+
+    //REVIEW should be StringUnionProperty<LauncherConfiguration>
     this.launcherConfigurationProperty = new Property<LauncherConfiguration>( initialAngle, launcherConfigurationOptions );
 
     const projectileTypeOptions = options.isProjectileTypePhetioInstrumented ? {
@@ -183,6 +185,7 @@ export default abstract class Field extends PhetioObject {
       phetioValueType: ProjectileType.ProjectileTypeIO
     } : { validValues: [ CANNONBALL ] } as const;
 
+    //REVIEW should be StringUnionProperty<ProjectileType>
     this.projectileTypeProperty = new Property<ProjectileType>( CANNONBALL, projectileTypeOptions );
 
     this.meanAngleProperty = new DerivedProperty( [ this.launcherConfigurationProperty ],

js/common/model/HistogramSonifier.ts

@@ -32,7 +32,7 @@ const MEAN_HIGHLIGHT_DURATION = 0.4;
 
 export default class HistogramSonifier {
 
-  //REVIEW document
+  //REVIEW document, should be StringUnionProperty<HistogramSonifierPhase>
   public readonly histogramSonifierPhaseProperty = new Property<HistogramSonifierPhase>( { phaseName: 'idlePhase' } );
 
   // The sorted data from the left to the rightmost bin

js/common/model/Launcher.ts

@@ -59,6 +59,7 @@ export default class Launcher extends PhetioObject {
 
     super( options );
 
+    //REVIEW should be StringUnionProperty<LauncherMechanism>
     this.launcherMechanismProperty = new Property( launcherMechanism, {
       tandem: options.tandem.createTandem( 'launcherMechanismProperty' ),
       phetioFeatured: true,

js/common/model/PDLModel.ts

@@ -116,6 +116,7 @@ export default abstract class PDLModel<T extends Field> implements TModel {
 
     this.histogram = new Histogram( () => this.shouldPlayMeanTone(), () => this.playMeanTone(), { tandem: providedOptions.tandem.createTandem( 'histogram' ) } );
 
+    //REVIEW should be StringUnionProperty<SingleOrContinuous>
     this.singleOrContinuousProperty = new Property<SingleOrContinuous>( 'single', {
       validValues: SingleOrContinuousValues,
       tandem: providedOptions.tandem.createTandem( 'singleOrContinuousProperty' ),

js/common/view/LauncherIconNode.ts

@@ -30,7 +30,7 @@ export default class LauncherIconNode extends Node {
   private launcherConfigurationProperty = new Property<LauncherConfiguration>( 'angle30' );
   private launchAngleProperty = new NumberProperty( 30 );
   private launchHeightProperty = new NumberProperty( 0 );
-  private mysteryOrCustomProperty = new Property<MysteryOrCustom>( 'mystery' );
+  private mysteryOrCustomProperty = new Property<MysteryOrCustom>( 'mystery' ); //REVIEW should be StringUnionProperty<MysteryOrCustom>
   private mysteryLauncherProperty = new Property( MYSTERY_LAUNCHERS[ 0 ] );
   private launcherMechanismProperty = new Property<LauncherMechanism>( SPRING );
   private standardDeviationAngleProperty = new Property( 0 );

js/sources/view/SourcesScreenView.ts

@@ -42,7 +42,7 @@ export default class SourcesScreenView extends VSMScreenView<SMField> {
         model.launcherConfigurationProperty,
         model.meanLaunchAngleProperty,
         model.launcherHeightProperty,
-        new Property( 'custom' ),
+        new Property( 'custom' ), //REVIEW should be new StringUnionProperty<MysteryOrCustom>( 'custom' )
         new Property( launcher ),
         model.customLauncherMechanismProperty,
         model.standardDeviationAngleProperty,