Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle backup strings for second language #13

Closed
chrisklus opened this issue Jan 5, 2023 · 3 comments
Closed

Handle backup strings for second language #13

chrisklus opened this issue Jan 5, 2023 · 3 comments
Assignees
Labels

Comments

@chrisklus
Copy link
Contributor

Because we are manually getting strings for the second language, like:

numberPlaySecondaryStrings[ `${NUMBER_PLAY_STRING_KEY_PREFIX}${stringKey}` ];

The sim crashes if the second language is missing a desired string key instead of gracefully filling in the English value like normal.

@chrisklus
Copy link
Contributor Author

Adding blocks-sim-publication label to indicate this should be completed before starting dev testing

pixelzoom added a commit that referenced this issue Jan 22, 2023
@pixelzoom
Copy link
Contributor

@chrisklus I believe that I've addressed this in the above commit. Please review, close if OK.

@chrisklus
Copy link
Contributor Author

@marlitas and I reviewed and made some changes in the above commits to support handling backup strings in number-compare as well, and then @pixelzoom @marlitas and I reviewed those changes together. I think we are set here, closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants