Speech synthesis locale gets out of sync with controls

[chrisklus]

Discovered by a partner teacher and @Nancy-Salpepi in #134 (comment) - when the screens change, the speech synthesis language does not necessarily match the locale toggle on the new screen. This is because there's a control for the locale on each screen, but only one global setting for the speech locale.

[chrisklus]

This was completed in the above commit, closing.

[chrisklus]

Also tagging #31

[Nancy-Salpepi]

This issue seems to be happening again for phetsims/qa#822 with mac + safari, but only when switching to the compare screen from either screen 1 or 2.

Steps:

1. Add ?secondLocale=es to url
2. Go to screen one and switch to Espanol
3. Press the Megaphone button
4. Switch to the compare screen and press the Megaphone button -- it will speak in Spanish even though the toggle is set to English

language.mov

It also happens in the other direction.

1. Go to the Compare screen and toggle to Espanol.
2. Press the Megaphone button--the statement is read in Spanish
3. Go to screen 1 or 2 and press the Megaphone button--the number is read in English
4. Go back to the Compare screen and press the Megaphone button-- it is the English voice speaking in Spanish

[Nancy-Salpepi]

I went back and tested 1.0.0-rc.1 again since I have updated my macOS and safari, and that version is working correctly.

[KatieWoe]

I repeated this on Win 11 Chrome. The correct words are read, but the wrong voice is used.

[KatieWoe]

This also occurs with the ?readAloud parameter.

[stemilymill]

I've gotten the same as Katie but with Win10 chrome, and also on Win10 firefox

[KatieWoe]

I wasn't able to reproduce on Win 11 Firefox due to #160.

[Nancy-Salpepi]

With the Chromebook and iPad, I am seeing what @KatieWoe reported in #152 (comment). Toggling back and forth fixes the issue.

[marlitas]

@jessegreenberg and I looked at this issue and were not able to reproduce because NumberCompare was moved out into it's own sim. We did not notice any speech synthesis bugs in switching between screens in NumberPlay. @jessegreenberg mentioned that if another screen using speech synthesis is added to NumberCompare code from 00f7ac1 will need to be added in number-compare-main as well. One way to do this may be to create a common NumberSuite sim that NumberCompare and NumberPlay extend from.

@Nancy-Salpepi can you confirm on your end wether you're able to reproduce something akin or not?

[Nancy-Salpepi]

@marlitas I'm not sure what is happening, but with mac + safari when I try to set the second locale, the sim freezes with this error:

When using mac + chrome, I can add the second locale and didn't notice any speech synthesis bugs.

[jessegreenberg]

Thanks @Nancy-Salpepi, promoting that to a new issue. Verifying this issue is blocked until that is fixed.

[jessegreenberg]

OK #204 is resolved, @Nancy-Salpepi sorry - should be able to test this again.

[Nancy-Salpepi]

Things look to be working correctly when switching between locales. I tested on the mac/iPad + safari.
However, sometimes the sim freezes when trying to add a second locale--see issue #205

[marlitas]

#205 is fixed and closed so I think this is also en-route to closure. @chrisklus back to you to confirm.

[chrisklus]

Just noting that #205 isn't fixed but I closed because it is being tracked in phetsims/number-suite-common#13.

Thanks @Nancy-Salpepi @KatieWoe @jessegreenberg @marlitas for working on this! I think we are good to close.