Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only English voice is heard #160

Closed
Nancy-Salpepi opened this issue Apr 15, 2022 · 14 comments
Closed

Only English voice is heard #160

Nancy-Salpepi opened this issue Apr 15, 2022 · 14 comments
Assignees
Labels

Comments

@Nancy-Salpepi
Copy link

Test device
MacBook Air (m1 chip)

Operating System
12.3.1

Browser
Safari

Problem description
For phetsims/qa#797

Using the query parameter secondLocale=es, I am only hearing the English speaking voice. When I switch to Español, it is the English voice saying the Spanish word. It is almost the opposite of what I originally reported in #134.

Steps to reproduce

  1. add the query parameter secondLocale=es
  2. Go to any screen and press the megaphone button to hear English
  3. Toggle to Español and then press the megaphone button

Visuals
Sorry for the birds chirping in this video!

only.english.mov
Troubleshooting information: !!!!! DO NOT EDIT !!!!! Name: ‪Number Play‬ URL: https://phet-dev.colorado.edu/html/number-play/1.0.0-rc.1/phet/number-play_all_phet.html?secondLocale=es Version: 1.0.0-rc.1 2022-04-14 15:43:27 UTC Features missing: touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/15.4 Safari/605.1.15 Language: en-US Window: 1403x701 Pixel Ratio: 2/1 WebGL: WebGL 1.0 GLSL: WebGL GLSL ES 1.0 (1.0) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 30 uniform: 256 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 16384x16384 OES_texture_float: true Dependencies JSON: {}
@Nancy-Salpepi Nancy-Salpepi added the type:bug Something isn't working label Apr 15, 2022
@KatieWoe
Copy link

KatieWoe commented Apr 15, 2022

I'm seeing this on Win 11 Firefox as well. It didn't seem to happen on Win 11 Chrome.

Image.from.iOS.1.MOV

@KatieWoe
Copy link

Oddly enough, iPadOS 15.4.1 Safari did not seem to have this issue.

@chrisklus
Copy link
Contributor

hmm thanks yall. for more data points, it is working correctly on my Mac 10.13 Safari 13 and my Mac Firefox.

@Nancy-Salpepi @KatieWoe are you seeing No voices found for locale: es or something like that in the console when it's not working?

@KatieWoe
Copy link

Yup
yup

@chrisklus
Copy link
Contributor

Great, thanks. So either these browser versions don't have Spanish languages (in this case of using es), or the code we have to select a voice for a given locale is not correctly looking for a matching voice

@Nancy-Salpepi
Copy link
Author

Oddly, nothing comes up in the console on the Mac.

@chrisklus
Copy link
Contributor

Hm, that is odd. I don't think there's any thing we can do about this this morning before publishing the prototype, so I'm going to mark for final publication to continue investigation later. For the prototype, it would be nice to include on the sim page that Chrome best supports this feature.

@Nancy-Salpepi
Copy link
Author

For phetsims/qa#822 I still see this issue with Win10 FF in 1.1.0-dev.1.
I can hear the Spanish speaking voice with Mac + safari.

@Nancy-Salpepi Nancy-Salpepi changed the title Only English voice is heard on Mac + safari Only English voice is heard Aug 1, 2022
@chrisklus chrisklus assigned marlitas and unassigned chrisklus Jan 12, 2023
@marlitas
Copy link
Contributor

This issue is currently being blocked by: #204

@jessegreenberg
Copy link
Contributor

#204 is no longer blocking. I am wondering if this issue predated the little warning button that a language is not available:
image

That may be the solution to this one, unless its still happening in other cases.

@marlitas
Copy link
Contributor

Yeah same observation as Jesse. My only thing is that now my secondLocale=es query parameter isn't working. I double checked but maybe I'm doing something wrong. @jessegreenberg and @chrisklus is that query parameter working for you?

@jessegreenberg
Copy link
Contributor

It worked as I expected, but I had to use both ?locales=*&secondLocale=es.

@marlitas
Copy link
Contributor

Okay thanks that's user error on my part then. I thought I could do locales=en&secondLocale=es thanks for that correction @jessegreenberg. This seems like it is fixed and no longer an issue with the warning button mentioned above. Sending over to @chrisklus to confirm and close if that feels like the right call.

@chrisklus
Copy link
Contributor

Thanks @jessegreenberg @marlitas - per what @jessegreenberg mentioned in #160 (comment), I think we are good to close. When we started dev testing, I'll make a note to keep an eye out for if there's ever a case where the voice doesn't work and there's no warning button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants