-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalize the sound implementation #233
Comments
@Ashton-Morris - I have added markers to the file
Please make any level adjustments that you feel are necessary, remove the comment, and assign this issue back to me when you're done. Please remember to reference this issue in any commits. |
@jbphet Here is the code for the mix
```
// Copyright 2014-2019, University of Colorado Boulder
/**
*/ // modules // strings // a11y strings // sounds // constants // Location of the top left corner of the observation window. // Corner radius of the observation window. // Line width of the observation window frame // TODO - @Ashton-Morris - please adjust level if needed, see #233 // X position at which the lamp emission sound is played, empirically determined /**
} moleculesAndLight.register( 'MoleculesAndLightScreenView', MoleculesAndLightScreenView ); return inherit( ScreenView, MoleculesAndLightScreenView, {
} );
|
@jbphet I did notice that the rotate sounds continue after you pause the scene. The absorb and vibrate stop properly when you pause during their playback but the rotate ones do not. |
I've fixed the issue with rotation and adjusted the output levels based on @Ashton-Morris's input. I also added in an absorption sound. Team: Please review the version at https://phet-dev.colorado.edu/html/molecules-and-light/1.5.0-dev.22/phet/molecules-and-light_en_phet.html?supportsSound and let me know what, if anything, you think needs to be changed. I for one would like a different sound for absorption of a photon by a molecule. |
Trying to listen on mobile and I'm not sure I hear an absorption sound. Is it a small atonal sound? It seems to blend in with the following phenomenon noise. |
Overall, it's sounding nice @jbphet! For dissociation (e.g. UV/ozone), I'm hearing a buzz that is triggered at the same time as the ripping sound when the bond breaks. I don't remember hearing this sound before, and I'm not sure what it's meant to represent. It also seems a little strange that the molecule RadioButtonGroup and the photon RadioButtonGroup have reversed pitches. For molecules the first option (carbon monoxide) corresponds to the highest pitch, while the first photon source (microwave) corresponds to the lowest pitch. While I can understand the ordering for the photon source -- a higher pitch corresponds to a higher frequency/energy, it seems inconsistent. I'm a bit wary of making changes to common component sounds, since the whole point is for them to be common. (Edit: After playing with ComboBox in Molarity (first option has the lowest pitch), I think the problem is with the molecule RadioButtonGroup. Should carbon monoxide have the lowest pitch?)
I did not hear an absorption sound at all. I was testing on my laptop using headphones. |
I think we need to raise the levels of the absorption sound so that it is more apparent to listeners. It if still doesn't stand out enough, then I need to rethink it. |
I've integrated the latest spatialized sounds for rotation and vibration (as discussed in #284) and they are now timed to match the slow-motion value discussed and decided upon in #295. To my knowledge, these are the last outstanding items for the sound design implementation. I'm going to assign this issue to all of the individuals who were in the most recent sound design review meeting for this sim for a final review of the sound design. Reviewers: Please try out the latest dev version at https://phet-dev.colorado.edu/html/molecules-and-light/1.5.0-dev.44/phet/molecules-and-light_en_phet.html, record any concerns or comments below, check yourself off, and unassign yourself. I'll follow up with @emily-phet if there are concerns that need to be addressed. Thanks in advance! |
The sim sounds awesome! And I see the photon fires immediately with both th e regular on/off button and with the Step Forward button! |
Sounds great to me! |
Sounds great to me as well. Also, I don't think there is any mixing needed as all the levels sound fairly even to me. If anyone has any volume issues let me know. |
Discussed in the 4/21/2020 sound design meeting, and have determined that the sound design is ready for publication. Closing. |
In #216 we started working on prototyping the sound design. The sounds have been selected, so it is now time to finalize the implementation. The main activities for this will be to remove the code that supports different option selections and to set the desired volume levels for all sounds.
The text was updated successfully, but these errors were encountered: