-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prototype the sound design #216
Comments
…he most recent review meeting, see #216
I have a version that is ready to review and get feedback on. It allows selection of different photon sounds via |
@Ashton-Morris and @emily-phet - there is a prototype available at the link in the comment just above this one. Please review and provide your comments, or we can review in real time at the next meeting. This version includes the current set of common UI sounds. |
Did a quick review - a few quick thoughts:
|
An issue that I'll need to address is that the sounds keep going if they are in progress when the pause button is pressed. @Matthew-phet noticed this too. |
Here are some notes from today's review meeting:
|
I've incorporated the feedback from the last meeting and some new sounds supplied by @Ashton-Morris into a new version, see https://phet-dev.colorado.edu/html/molecules-and-light/1.5.0-soundDesignProto01.3/phet/molecules-and-light_en_phet.html?supportsSound. Remember that different sounds can be selected using the "Options..." dialog from the PhET menu. We will review at today's meeting and decide which configurations we like best and what the next steps should be. |
Review during 10/22/2019 meeting
|
After using the sim quite a bit, I'd like to suggest that we soften the attack of the primary photon emission sound (i.e. when they come out of the sources). I like the basis of the sound itself, but it wears on my a bit if I use the sim for a while, and it think it's the strong "ping" at the onset of the sound that's causing this effect for me, and I think softening the attack will help. |
I agree with @jbphet, the light sources are little loud. I always find the reset button loudish ;-) I have no idea if anyone else feels this way. |
Generally on board with JB & TS. It does feel a little like something is being physically hit with the light souecw, though I still like the quality of the tone after the attack. Also, I agree on the break-apart volume. It seems to me that clicking the Light Spectrum button is louder than the molecule breaking apart? Though that could be wrong. Doesn't seem like it needs to change too much. For me the rotation is fine, but it seems more subtle with that primary photon attack dominating the noise-space for me. I think it might be less subtle after that has been diminished? |
I think the emitting photon sounds good but the main photon might have too much attack to it. I agree the reset is louder. We should bring up the levels of the other sounds a bit to adjust to that. |
Notes from 11/2/2019 review meeting:
Adding @Ashton-Morris as an assignee for the rotation sounds. I'll follow up on the other items. |
Notes from 12/3/2019 review meeting:
The dev version at https://phet-dev.colorado.edu/html/molecules-and-light/1.5.0-dev.17/phet/molecules-and-light_en_phet.html?supportsSound has all of these as the default sounds. This is probably the last version that I'll publish with options, since we've agreed upon the sounds. |
The next step will be to work out the mix. |
The prototyping work is essentially complete, and the sound selections have been finalized. Various published versions of the prototypes can be found at the links in comments above. I'm going to close the issue and track the final implementation steps in #233. |
The sound design group has been working on a sound design for this sim for a while, and even created an initial shot at the sound design a while back that can be seen (and heard) at https://phet-dev.colorado.edu/html/phet-io-wrapper-sonification/1.0.0-dev.125/build/phet-io-wrapper-sonification/molecules-and-light/html/molecules-and-light-sonification.html?accessibility. A decision was recently made to do sound prototypes on master rather than in phet-io wrappers, so this issue is about implementing that sound design.
This issue will track the commits for adding the sound design prototype and the feedback on it. Once the design is finalized, a separate issue should be created for completing the sound implementation.
The text was updated successfully, but these errors were encountered: