Skip to content

Commit

Permalink
removed recently added photonAbsorbedEmitter, since it isn't actually…
Browse files Browse the repository at this point in the history
… needed, see #216
  • Loading branch information
jbphet committed Oct 8, 2019
1 parent 2928e77 commit b62dbd2
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions js/photon-absorption/model/Molecule.js
Original file line number Diff line number Diff line change
Expand Up @@ -142,9 +142,6 @@ define( require => {
// @public, set by PhotonAbsorptionModel
this.photonGroupTandem = null;

// @public (read-only) {Emitter} - emitter for when a photon is absorbed
this.photonAbsorbedEmitter = new Emitter( { parameters: [ { valueType: Photon } ] } );

// @public (read-only) {Emitter} - emitter for when a photon is emitted
this.photonEmittedEmitter = new Emitter( { parameters: [ { valueType: Photon } ] } );

Expand Down Expand Up @@ -432,9 +429,9 @@ define( require => {
absorbPhoton = true;
this.activePhotonAbsorptionStrategy = candidateAbsorptionStrategy;
this.activePhotonAbsorptionStrategy.queryAndAbsorbPhoton( photon );
this.photonAbsorbedEmitter.emit( photon );
}
else {

// We have the decision logic once for whether a photon should be absorbed, so it is not queried a second
// time.
this.markPhotonForPassThrough( photon );
Expand Down

0 comments on commit b62dbd2

Please sign in to comment.