Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General layout and struts #256

Closed
jonathanolson opened this issue Mar 13, 2018 · 1 comment
Closed

General layout and struts #256

jonathanolson opened this issue Mar 13, 2018 · 1 comment
Assignees
@Denz1994
Labels
dev:code-review

Comments

@jonathanolson
Copy link
Contributor

It would be good to talk about layout sometimes, as using struts is typically not commonly needed/desired, except in certain cases.

For collaboration, let's look through every layout where struts are currently used.

#253
Denz1994 referenced this issue May 9, 2018
@Denz1994
Removing use of hStruts for alignments. #253 #258.
885de3c
Denz1994 referenced this issue May 9, 2018
@Denz1994
Removing more usages of hStruts for text alignments. #253 #258.
9e5715d
Denz1994 referenced this issue May 9, 2018
@Denz1994
Removing more usages of hStruts for text alignments. #253 #258.
a061ece
Denz1994 added a commit that referenced this issue May 15, 2018
@Denz1994
Layout based on visibility bounds refactored for OneSpringView #253 #256
59fd8c3 
.
Denz1994 added a commit that referenced this issue May 15, 2018
@Denz1994
Layout bug fixed for OneSpringView. #253 #256.
14ea136
Denz1994 added a commit that referenced this issue May 15, 2018
@Denz1994
Layout of Panels/Nodes refactored for TwoSpringView. #253 #256.
adea0ad
Denz1994 added a commit that referenced this issue May 15, 2018
@Denz1994
Refactored layout for vectorScreenView. #253 #256.
137e5be
Denz1994 added a commit that referenced this issue May 15, 2018
@Denz1994
Simplified layouts for intro, vectors, and lab screen views. #253 #256.
f1d7a9f
Denz1994 added a commit that referenced this issue May 15, 2018
@Denz1994
Exposing gravityAndDampingControlNode to SpringScreenView with option…
be29567 
…s for each screen to toggle slider visibilities. #256, #253
@Denz1994
Copy link
Contributor

After much refactoring and some review with @jonathanolson, the use of struts has been minimalized. Proper alignments have been given to view elements without the use of manually applying struts. Closing this issue.

@Denz1994 Denz1994 mentioned this issue May 15, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Denz1994 Denz1994

Labels
dev:code-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonathanolson @Denz1994