-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate global sound controls into sim framework #497
Comments
I committed some code for this but forgot to reference the issue, please see 4dd92fc. |
…ambo#12, phetsims/joist#497 Signed-off-by: Chris Malley <[email protected]>
…rder, phetsims/tambo#12, phetsims/joist#497 Signed-off-by: Chris Malley <[email protected]>
@jbphet said:
RCs are published for Equality Explorer, so you may proceed with merging into master. |
@samreid - since the Equality Explorer RC is out, please review the code on the sound-control branch and let me know what if anything needs to be done before merging it to master. One exception: for now, please don't spend any time on |
…stead of using font awesome icons, see phetsims/tambo#19 and #497
In the preceding 3 commits (note these are for 3 repos), I added review comments for the proposed changes. @jbphet please take a look? |
I ran @jbphet I believe the config files are now correct. Is there some place we should document how to update dependencies? |
Thanks for the fix.
Sure. Maybe a new document in |
Added phet-info/checklists/updating_metadata.md (fits as a checklist). Tagging for developer meeting to see if anything needs to change. |
There are two sound controls that need to be added into the sim framework, one for turning sound on and off for the sim, and another for choosing between "basic" and "enhanced" sounds.
The issues where this was previously discussed are:
The UI design is being finalized in:
In the 7/9/2018 sonification framework design meeting we decided that this should be committed to a branch on joist until the Equality Explorer release branch is created in order to minimize the risk of destabilizing core framework code.
The text was updated successfully, but these errors were encountered: