Skip to content

Commit

Permalink
Added // REVIEW comments for proposed changes for integration of tamb…
Browse files Browse the repository at this point in the history
…o with joist, see phetsims/joist#497
  • Loading branch information
samreid committed Jul 18, 2018
1 parent 91fe862 commit ad1b1fe
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions js/TamboQueryParameters.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

/**
* Query parameters supported by this simulation.
* REVIEW: This documentation is incorrect.
*
* @author Aadish Gupta
*/
Expand All @@ -11,6 +12,8 @@ define( function( require ) {
// modules
var tambo = require( 'TAMBO/tambo' );

// REVIEW: Tambo query parameters should be in initialize-globals

var TamboQueryParameters = QueryStringMachine.getAll( {

// use the stubbed audio context regardless of whether support exists for Web Audio
Expand All @@ -23,6 +26,7 @@ define( function( require ) {
},

// control whether enhanced sound mode is initially enabled (user can change later)
// REVIEW: there is a discrepancy between this query string key and the preceding one
enhancedSoundEnabled: {
type: 'boolean',
defaultValue: false
Expand Down

0 comments on commit ad1b1fe

Please sign in to comment.