Skip to content

Commit

Permalink
Added // REVIEW comments for proposed changes for integration of tamb…
Browse files Browse the repository at this point in the history
…o with joist, see phetsims/joist#497
  • Loading branch information
samreid committed Jul 18, 2018
1 parent 6d7a5fc commit d114bb9
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions js/initialize-globals.js
Original file line number Diff line number Diff line change
Expand Up @@ -435,7 +435,7 @@

/**
* Indicates whether the tambo sound library should be enabled. If true, an icon is added to the nav bar icon to
* enable the user to turn sound on/off.
* enable the user to turn sound on/off. There is also a Sim option for tambo which can override this.
* Primarily for internal use, though we may share links with collaborates that use this parameter.
*/
tambo: { type: 'flag' },
Expand Down Expand Up @@ -543,7 +543,7 @@
* @public (writable by joist) can be overwritten in the constructor of Sim.js
* @type {boolean}
*/
window.phet.chipper.supportsEnhancedSound = phet.chipper.queryParameters.supportsEnhancedSound;
window.phet.chipper.supportsEnhancedSound = phet.chipper.queryParameters.supportsEnhancedSound; // REVIEW: See other note in Sim.js about not using a global for this

/**
* Utility function to pause synchronously for the given number of milliseconds.
Expand Down

0 comments on commit d114bb9

Please sign in to comment.