Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LoL: Sound Continues After Pause #309

Closed
KatieWoe opened this issue Sep 26, 2018 · 6 comments
Closed

LoL: Sound Continues After Pause #309

KatieWoe opened this issue Sep 26, 2018 · 6 comments
Assignees
@KatieWoe
Labels
type:bug

Comments

@KatieWoe
Copy link
Contributor

Device
Dell Laptop
OS
Win 10
Browser
Firefox
Problem Description
For phetsims/qa#196
When in LoL the humming sound of the electrons continues even after the sim is paused. If you pause in the middle of a discharge, the zap sound continues as well.
Steps to Reproduce

  1. Enter the sim into the LoL harness and start it.
  2. Add electrons.
  3. Pause the sim with LoL.
@KatieWoe
Copy link
Contributor Author

P.S. Ive been marking legends of learning pass on the testing matrix. Should it be marked fail due to this issue? Also, it is not restricted to firefox.

@jbphet
Copy link
Contributor

jbphet commented Sep 27, 2018

@KatieWoe - in my opinion, it would be good to mark this as having failed. In either case, I'll address it.

jbphet added a commit to phetsims/tambo that referenced this issue Oct 1, 2018
@jbphet
disable sound production when sim is not active, see phetsims/john-tr…
fe63321 
…avoltage#309
jbphet added a commit to phetsims/joist that referenced this issue Oct 1, 2018
@jbphet
disable sound production when sim is not active, see phetsims/john-tr…
2032a80 
…avoltage#309
@jbphet jbphet mentioned this issue Oct 1, 2018
Open
@jbphet
Copy link
Contributor

jbphet commented Oct 1, 2018

I've implemented a solution for this where sound generation is disabled when the sim is inactive. It works well in this context, but I think long term I'll implement a more complete solution, and I've described that in phetsims/tambo#51.

I think this fix is sufficient for now. I'll leave this issue open to remind me to propagate the fix to the 1.5 release branch and have it tested there on the next RC.

@jbphet jbphet removed their assignment Oct 1, 2018
@jbphet
Copy link
Contributor

jbphet commented Oct 1, 2018

@KatieWoe - isn't this bug a duplicate of #306? Please let me know and, if so, close that one (not this one) since I've referenced my commits to this issue.

@KatieWoe
Copy link
Contributor Author

KatieWoe commented Oct 2, 2018

@jbphet it looks like. Sorry about that.

@KatieWoe KatieWoe mentioned this issue Oct 2, 2018
Closed
jbphet added a commit that referenced this issue Oct 2, 2018
@jbphet
updated dependencies to latest version of tambo, see #309 and #314
88af007
jbphet added a commit to phetsims/joist that referenced this issue Oct 2, 2018
@jbphet
disable sound production when sim is not active, see phetsims/john-tr…
dcfbcf6 
…avoltage#309

(cherry picked from commit 2032a80)
jbphet added a commit that referenced this issue Oct 2, 2018
@jbphet
updated to patched version of joist, see #309
e96aec8
@jbphet jbphet mentioned this issue Oct 3, 2018
Closed
6 tasks
@KatieWoe
Copy link
Contributor Author

KatieWoe commented Oct 4, 2018

Looks good 1.5.0-rc.2

@KatieWoe KatieWoe closed this as completed Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KatieWoe KatieWoe

Labels
type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbphet @KatieWoe