Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC Spot Check: John Travoltage 1.5.0-rc.2 #200

Closed
6 tasks done
jbphet opened this issue Oct 3, 2018 · 7 comments
Closed
6 tasks done

RC Spot Check: John Travoltage 1.5.0-rc.2 #200

jbphet opened this issue Oct 3, 2018 · 7 comments

Comments

@jbphet
Copy link
Contributor

jbphet commented Oct 3, 2018

@KatieWoe and @ariel-phet, John Travoltage 1.5.0-rc.2 is ready for RC testing. Testing on 1.5.0-rc.1 was completed, several issues have been addressed, and this is the follow up test. For the most part, a full test on all platforms is not necessary, just a verification of the issues and spot testing on key platforms. The exception is that a full test should be performed on Internet Explorer, since a bug blocked testing of the previous RC.

Please document issues in https://github.com/phetsims/john-travoltage/issues and link to this issue.

Assigning @ariel-phet for prioritization.

General RC Test

What to Test

  • One if the issues that was addressed was related to when electrons are added to the body based on foot movements (see issue list below). Special care should be taken to make sure that nothing is broken with this behavior.
  • The addition of sound was the primary purpose of this release. While nothing has changed with respect to sound for this release, it's still good to pay close attention to it.

Issues to Verify

These issues should have the "status:fixed-pending-testing" label. Check these issues off and change their status to fixed-awaiting-deploy if resolved. Otherwise, post a comment in the issue saying that it wasn't fixed.

Link(s)


FAQs for QA Members
There are multiple tests in this issue... Which test should I do first?

Test in order! Test the first thing first, the second thing second, and so on.


How should I format my issue?

Here's a template for making issues:

  <b>Test Device</b>

  blah

  <b>Operating System</b>

  blah

  <b>Browser</b>

  blah

  <b>Problem Description</b>

  blah

  <b>Steps to Reproduce</b>

  blah

  <b>Visuals</b>

  blah

  <details>
  <summary><b>Troubleshooting Information</b></summary>

  blah

  </details>

Who should I assign?

We typically assign the developer who opened the issue in the QA repository.


My question isn't in here... What should I do?

You should:

  1. Consult the QA Book.
  2. Google it.
  3. Ask Katie.
  4. Ask a developer.
  5. Google it again.
  6. Cry.


@ariel-phet
Copy link
Contributor

@KatieWoe current top testing priority

@KatieWoe
Copy link
Contributor

KatieWoe commented Oct 3, 2018

Devices to Test On (@jbphet let me know if you have any changes you want):

  • Win 10 Chrome full
  • Win 10 Edge full
  • Win 10 Firefox full + Jaws + NVDA

  • Mac OS 10.14 Chrome partial
  • Mac OS 10.14 Safari full + Voice over
  • Mac OS 10.14 Firefox partial

  • Win 8.1 IE full
  • Win 7 IE full

  • Mac OS 10.13 Chrome partial
  • Mac OS 10.13 Safari partial
  • Mac OS 10.13 Firefox partial

  • Chrome OS partial

  • iOS 12 partial
  • iOS 11 partial

@KatieWoe
Copy link
Contributor

KatieWoe commented Oct 3, 2018

Just tested all the screen readers. If time permits, another look from a second tester would be nice.

@jbphet
Copy link
Contributor Author

jbphet commented Oct 3, 2018

The list of devices on which to test looks good to me.

@KatieWoe
Copy link
Contributor

KatieWoe commented Oct 4, 2018

@jbphet @jessegreenberg QA is done

@KatieWoe KatieWoe removed their assignment Oct 5, 2018
@jbphet
Copy link
Contributor Author

jbphet commented Oct 9, 2018

I checked in with the phet-io folks to make sure that one of the issues linked above isn't seen as blocking the release. Here is a record of the dialog:

@jbphet [12:16 PM]
Issue phetsims/scenery#861 is referenced in the RC test ticket for John Travoltage, see #200. I've read through it, and my impression is that I don't need to take any action related to this issue for the in-process release branch for JT, which is the 1.5 branch. Do you phet-io gurus concur?

@zepumph [12:24 PM]
That's correct thanks for checking.

@jbphet
Copy link
Contributor Author

jbphet commented Oct 9, 2018

Thanks for testing, I'll close this and follow up on the one issue that resulted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants