You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For phetsims/qa#196 when using Legends of Learning and pausing it the simulation pauses as intended. However if the sim is paused while John is getting shocked the sound will continue to play until the sim is resumed and all of the charges are discharged.
The text was updated successfully, but these errors were encountered:
Nice catch. I just took a look at this with @samreid, and he pointed me to the file 'LegendsOfLearningSupport.js, where the pausing is handled. Based on what we see in this sim, pausing the sim causes the globally available property phet.joist.sim.activeProperty` to go false. The sound manager should probably monitor this property and pause sounds when this happens.
I'll investigate doing this, or something similar, as a fix for this issue.
Just to let you guys know but the continuous sound that plays to indicate a charge on John also continues to play when the sim is paused using Legends of Learning.
For phetsims/qa#196 when using Legends of Learning and pausing it the simulation pauses as intended. However if the sim is paused while John is getting shocked the sound will continue to play until the sim is resumed and all of the charges are discharged.
The text was updated successfully, but these errors were encountered: