Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legends Of Learning Doesn't Pause Sound #306

Closed
JRomero0613 opened this issue Sep 26, 2018 · 3 comments
Closed

Legends Of Learning Doesn't Pause Sound #306

JRomero0613 opened this issue Sep 26, 2018 · 3 comments
Assignees
Labels

Comments

@JRomero0613
Copy link

For phetsims/qa#196 when using Legends of Learning and pausing it the simulation pauses as intended. However if the sim is paused while John is getting shocked the sound will continue to play until the sim is resumed and all of the charges are discharged.

@jbphet
Copy link
Contributor

jbphet commented Sep 26, 2018

Nice catch. I just took a look at this with @samreid, and he pointed me to the file 'LegendsOfLearningSupport.js, where the pausing is handled. Based on what we see in this sim, pausing the sim causes the globally available property phet.joist.sim.activeProperty` to go false. The sound manager should probably monitor this property and pause sounds when this happens.

I'll investigate doing this, or something similar, as a fix for this issue.

@JRomero0613
Copy link
Author

Just to let you guys know but the continuous sound that plays to indicate a charge on John also continues to play when the sim is paused using Legends of Learning.

@KatieWoe
Copy link
Contributor

KatieWoe commented Oct 2, 2018

Duplicate of #309 closing for @jbphet

@KatieWoe KatieWoe closed this as completed Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants