-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it possible to set color of text labels on BarChartNode #49
Comments
This is done. There is now an entry to the "bar" object called
This would impact pendulum-lab and masses-and-springs. I kept the labels with their colors for now. @arouinfar can you confirm that the labels in these sims should be black? |
@jessegreenberg yes, I think we should change the labels in pendulum-lab and masses-and-springs to black. In the graph, the text is right next to the bar so I don't think an extra level of color-cueing is necessary. These sims do have an energy legend that I think we'll need to make some design tweaks to, so I'll open an issue in the sim repos.
|
OK thanks @arouinfar - since you have made issues for the above two sims I think this issue can be closed. |
@jessegreenberg I opened issues to fix the Energy Legend dialog which use the same colors as the bar graph labels, but I'd assumed the graph labels would be changed to black in this issue. Can you make this change, or should I open issues in the sim repos for that as well? |
Ah sorry, I thought those issues included the change to the graphs as well. I can definitely do that here. |
OK, labels have been made black. Anything else to do @arouinfar? |
Looks good in master, thanks @jessegreenberg! |
They currently match the color of the bar only.
The text was updated successfully, but these errors were encountered: