Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Energy Legend: make all text black and add color swatches #217

Open
arouinfar opened this issue May 1, 2020 · 0 comments
Open

Energy Legend: make all text black and add color swatches #217

arouinfar opened this issue May 1, 2020 · 0 comments
Assignees

Comments

@arouinfar
Copy link
Contributor

arouinfar commented May 1, 2020

In phetsims/griddle#49, labelColor was added to bar graphs, and the is default black. The primary motivation for this change was the contrast ratio between the colored text and the white background was poor (see values in phetsims/griddle#49 (comment)).

Another place that the colored text appears is in the Energy Legend:
image

All text should be made black, but to compensate, we should add a color swatch next to each entry.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants