-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Energy Legend: make all text black and add color swatches #359
Comments
The color swatches have been added to the legend. Can @arouinfar review this change on master? |
Looks great, thanks @Denz1994! |
…apping. Addressing more REVIEW statements. phetsims/masses-and-springs#359
In 1.1.0-dev.2, all text is now black and color swatches have been added. @arouinfar, I'm not sure the black color swatch for Total Energy makes sense anymore now that all of the labels are black. It's bar is a combo of all the other colors, not black. Thoughts? EDIT: Actually, I see that the bar can be a dark gray when the spring is really stretched. |
Good find @Nancy-Salpepi. Black is definitely an inappropriate choice for the total Energy swatch. The stacked color representation only works if all of the values are positive, but the gravitational PE is sometimes negative. When that happens, we represent the total energy with a solid gray bar. @jbphet let's change the total energy swatch color to the dark gray we use for the bar. |
Tagging for phetsims/qa#936 |
Unassigning and marking as "blocks-sim-publication" since the republication of this sim has been deprioritized for now. This should be addressed (at least to some degree) before republishing. |
In phetsims/griddle#49,
labelColor
was added to bar graphs, and the is default black. The primary motivation for this change was the contrast ratio between the colored text and the white background was poor (see values in phetsims/griddle#49 (comment)).Another place that the colored text appears is in the Energy Legend:
All text should be made black, but to compensate, we should add a color swatch next to each entry.
The text was updated successfully, but these errors were encountered: