-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a query parameter for default temperature units #186
Comments
I just looked through the code base, and I'm not finding a precedent for being able to set the units to any of the allowable values. Instead, in state-of-matter and number-line-integers, I'm seeing a parameter called I'm going to start of with a different approach here. I'll create a query parameter called |
@arouinfar - This is now implemented as described in the previous comment. It works for the first two screens, but not for the third one, since temperature units control is not yet implemented for that screen. Please check it out, and let me know if this seems like it will work. We can change the query parameter and values if you have thoughts on how to improve it. |
This looks great to me @jbphet. I opened up phetsims/states-of-matter#361 to do the same in SOM(B) when it's republished off of master. I don't think there's anything else we need to do for this issue, since adding a user-facing control to the Options/Preferences dialog is being tracked in #187. |
This has been done for other sims (I think SOM is an example), so we should do it in a similar way.
The text was updated successfully, but these errors were encountered: