Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query parameter to start sim using Celsius #216

Closed
oliver-phet opened this issue May 25, 2018 · 10 comments
Closed

Query parameter to start sim using Celsius #216

oliver-phet opened this issue May 25, 2018 · 10 comments

Comments

@oliver-phet
Copy link

A collaborator requested that the sim start using Celsius rather than Kelvin. @jbphet thought this should be done using a query parameter.

Waiting to confirm with collaborator before we start instrumenting this.

@oliver-phet oliver-phet self-assigned this May 25, 2018
@oliver-phet
Copy link
Author

It would be ideal for him, if he know where he could define the code of standart (Celsius) for the correspondent Dropdown. As the sims will run for 10 to 15 years, he could change the standard every time he would have to update the version without contacting you again.

@jbphet It sounds like it would be great if we could add a query parameter to allow the sim to start using Celsius.

@jbphet
Copy link
Contributor

jbphet commented Jul 23, 2018

Added in 6c2a42c (forgot to reference this issue in the commit).

@jbphet
Copy link
Contributor

jbphet commented Jul 23, 2018

I added the query parameter defaultCelsius for this feature, seems to work well. The readout will return to Celsius if it is changed to Kelvin and then the screen is reset.

Leaving open and unassigned until tested and published.

DO NOT CLOSE THIS ISSUE until the feature has been published and we have informed the user who requested the feature that it is now available.

@oliver-phet
Copy link
Author

@jbphet Was there a issue created in QA to test this?

@jbphet
Copy link
Contributor

jbphet commented Aug 28, 2018

There will be for the next RC.

@phet-steele
Copy link

Looks good in 1.1.0-rc.1 Win 10 Chrome. From the commit, I can't imagine this needing more testing on other platforms.

DO NOT CLOSE THIS ISSUE until the feature has been published and we have informed the user who requested the feature that it is now available.

@jbphet let @oliver-phet know when this is out!

@jbphet
Copy link
Contributor

jbphet commented Sep 24, 2018

Unassigning but leaving open so that we remember to tell the person who requested it when it's available.

@jbphet
Copy link
Contributor

jbphet commented Oct 29, 2018

@oliver-phet - please tell the individual who requested this that it is now live.

@oliver-phet
Copy link
Author

Email sent. Closing.

@KatieWoe
Copy link
Contributor

This is also looking ok in SOMB 1.1.0-rc.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants