Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use defaultTemperatureUnits instead of defaultCelsius and add control to the Options dialog #361

Open
2 tasks
arouinfar opened this issue Jul 5, 2022 · 1 comment
Assignees

Comments

@arouinfar
Copy link
Contributor

arouinfar commented Jul 5, 2022

In #216 we created the defaultCelsius query parameter to set the default temperature units to Celsius. This query parameter has never been shared with users in the Teacher Tips or with PhET-iO clients in phet-io-guide.md.

In greenhouse-effect we created a similar query parameter defaultTemperatureUnits that takes values of F, C, and K, see phetsims/greenhouse-effect#186. This approach is preferable because we now have validation of query parameter values. This pattern also translates better into a user-facing control in the Options Dialog.

Next time this simulation is published off of master let's make these changes @jbphet:

  • Deprecate defaultCelsius in favor of defaultTemperatureUnits
  • Add corresponding RadioButtonGroup to the Options dialog

This applies to both SOM and SOMB.

@jbphet
Copy link
Contributor

jbphet commented Jul 5, 2022

Sound reasonable. This sim, I believe, is slated to have its phet-io implementation updated to the latest and greatest reasonably soon. I'm going to defer this particular issue now, and when the sim is getting some focus for the phet-io update, we can undefer and implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants