-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change help text for Measure Distance Ruler (keyboard only) #216
Comments
This is done in GFL, and while I was there I changed the two other usages in Friction and BASE as they seemed the same. Can you please review. |
@zepumph, thanks for pointing out the changes in BASE and Friction. The initial grab response in all cases (GFL, BASE, and Friction) contains device-dependent essential information about moving with the WASD keys or dragging with the finger. This change removed duplication and makes our PDOM content more general. I noticed the Balloon in BASE is not draggable. I'll open a separate issue for that - not sure when that happened. The ruler and the book work just fine. |
@zepumph, except for the issue with BASE which may or may not be related, this issue is done in my opinion. |
Closing, please re-open if you need to re-open. |
Related to design changes outlined in #215, I have decided to remove the lengthy and not very helpful reference to the WASD keys in the Measure Distance Ruler's help text that is always available on-demand in the State Descriptions in the PDOM.
Please change the bolded platform specific help text in the curly braces from:
TO:
The text was updated successfully, but these errors were encountered: