Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change help text for Measure Distance Ruler (keyboard only) #216

Closed
terracoda opened this issue Nov 29, 2019 · 5 comments
Closed

Change help text for Measure Distance Ruler (keyboard only) #216

terracoda opened this issue Nov 29, 2019 · 5 comments

Comments

@terracoda
Copy link
Contributor

terracoda commented Nov 29, 2019

Related to design changes outlined in #215, I have decided to remove the lengthy and not very helpful reference to the WASD keys in the Measure Distance Ruler's help text that is always available on-demand in the State Descriptions in the PDOM.

Please change the bolded platform specific help text in the curly braces from:

  • If needed, grab ruler to measure distance between centers of spheres. {{Once grabbed, use keyboard shortcuts or letter keys W, A, S, or D to move ruler up, left, down, or right.}}

TO:

  • If needed, grab ruler to measure distance between centers of spheres. {{Once grabbed, use keyboard shortcuts to move ruler.}}
@terracoda
Copy link
Contributor Author

@zepumph, while you are working on #215 it makes sens to do this related issue as well.

zepumph added a commit to phetsims/balloons-and-static-electricity that referenced this issue Dec 31, 2019
@zepumph
Copy link
Member

zepumph commented Dec 31, 2019

This is done in GFL, and while I was there I changed the two other usages in Friction and BASE as they seemed the same. Can you please review.

zepumph added a commit to phetsims/inverse-square-law-common that referenced this issue Dec 31, 2019
@zepumph zepumph assigned terracoda and unassigned zepumph Dec 31, 2019
zepumph added a commit to phetsims/friction that referenced this issue Dec 31, 2019
@terracoda
Copy link
Contributor Author

@zepumph, thanks for pointing out the changes in BASE and Friction.
This simplified help text in the actual PDOM is good as it is platform/device independent.

The initial grab response in all cases (GFL, BASE, and Friction) contains device-dependent essential information about moving with the WASD keys or dragging with the finger.

This change removed duplication and makes our PDOM content more general.

I noticed the Balloon in BASE is not draggable. I'll open a separate issue for that - not sure when that happened. The ruler and the book work just fine.

@terracoda
Copy link
Contributor Author

@zepumph, except for the issue with BASE which may or may not be related, this issue is done in my opinion.

@terracoda
Copy link
Contributor Author

Closing, please re-open if you need to re-open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants