-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PDOM order change: Considering putting Measure Distance Ruler in Play Area #204
Comments
This would be an easy change, just involving some rearranging in the screen view file. Let me know if you would like me to implement this. |
Ok, good to know. No action required yet. I want to be sure before we move it up higher in the Tab order. |
@zepumph, once #215 and #216 are implemented, I think it is safe to move the Measure Distance Ruler to come after the Mass Controls, ensuring it is not inside any grouping related to the Mass Controls, and before the Control Area. Once it is moved, I we will need to update the screen summary. I'll make a new issue for that. |
@terracoda, this was implemented above, please review. |
Verified. Thanks! |
@zepumph, how difficult is it to change the focus order of the Ruler and it's help text?
Once we changed the "Grab Ruler" to a "Measure Distance Ruler" button, it seemed it might be safe to have it back in the Play Area in its original position.
@zepumph, is something that is not so difficult to do, or is it quite involved?
I am a little worried about moving it since things are not yet working for gesture yet, and also a little curious if moving it would make the moving through the PDOM with gestures easier.
Please let me know the scope of changing the PDOM order of the Ruler.
The text was updated successfully, but these errors were encountered: