Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Balloon is no longer moveable (keyboard) #462

Closed
terracoda opened this issue Dec 31, 2019 · 1 comment
Closed

Balloon is no longer moveable (keyboard) #462

terracoda opened this issue Dec 31, 2019 · 1 comment
Assignees
Labels

Comments

@terracoda
Copy link
Contributor

terracoda commented Dec 31, 2019

A generalizable change to GFL's ruler's help text was made to BASE and Friction. See phetsims/gravity-force-lab#216 (comment)

While verifying the content change in BASE, I noticed the Balloon was not draggable with the keyboard. WASD and Arrow keys do not work when balloon is grabbed. I can jump the balloon, though with special jump keys (JW, JS, and JC).

I have NOT tested the interaction on mobile.

I am not sure when the balloon stopped moving. The changes that @zepumph made were likely only content related. The book in Friction and the ruler in GFL are still draggable with the keyboard and work fine.

Assigning to @zepumph and @jessegreenberg. Please adjust assignment as needed.

@zepumph
Copy link
Member

zepumph commented Jan 21, 2020

In 41e3884 "locationProperty" was changed to "positionProperty" for a KeyboardDragListener listener as part of phetsims/phet-info#126, but the KeyboardDragListener api was not changed until I just committed. This should be fixed now, tested on master. Closing

@zepumph zepumph closed this as completed Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants