-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edge case alerts when changing mass need some corrections #90
Comments
@zepumph, if you can get the description going in the correctly, great if not - do not worry. |
This was a pretty big change. It seems to be working as expected now. Please review. |
Sometimes it seems like there is a key press delay, where the "pushed mass" value text is one key press behind. But I can't get that to occur consistently, and it doesn't seem too distracting for right now. Let me know what you think. |
@zepumph, I verified that all the alerts are firing correctly. |
Actually, I will go ahead and do just that - start a new issue. |
As I mentioned in phetsims/gravity-force-lab#135 (comment), these edge case alerts have been correctly implemented in REGULAR, but are not always correct over here in BASICS. This might be due to lack of time for @mbarlow12 to finish these edge cases for both sims.
Here are screen shots of BASICS showing where the alerts are correct and incorrect.
@zepumph, please make the alerts work correctly like in REGULAR. Once they are correct, we can see where we will need tweaks to better align visual movement and the description of the visual movement.
Incorrect: Mass 1's mass increases and pushes Mass 2 right
Alert incorrectly describes mass 1 as moving left.
Incorrect: Mass 2 pushes Mass 1 left
Alert incorrectly describes mass 2 as moving right.
Incorrect alert when changing sphere is at edge pushing other mass away
Incorrect alert: Same issue when increasing mass of Mass 2 when Mass 2 is at right edge
Correct alert when unchanging sphere is at edge
Increasing mass of Mass 1 when Mass 2 is at right edge. In this case the alert is correctly describes mass 1 as moving left.
Increasing mass of Mass 2 when Mass 1 is at left edge. Again, alert correctly describes mass 2 as moving right.
The text was updated successfully, but these errors were encountered: