Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge case alerts when changing mass need some corrections #90

Closed
terracoda opened this issue Jan 22, 2019 · 5 comments
Closed

Edge case alerts when changing mass need some corrections #90

terracoda opened this issue Jan 22, 2019 · 5 comments

Comments

@terracoda
Copy link

As I mentioned in phetsims/gravity-force-lab#135 (comment), these edge case alerts have been correctly implemented in REGULAR, but are not always correct over here in BASICS. This might be due to lack of time for @mbarlow12 to finish these edge cases for both sims.

Here are screen shots of BASICS showing where the alerts are correct and incorrect.

@zepumph, please make the alerts work correctly like in REGULAR. Once they are correct, we can see where we will need tweaks to better align visual movement and the description of the visual movement.

Incorrect: Mass 1's mass increases and pushes Mass 2 right
Alert incorrectly describes mass 1 as moving left.
mass1-increase-moves-mass2right-incorrect-alert
mass1-increase-pushes-mass2-right-incorrect alert

Incorrect: Mass 2 pushes Mass 1 left
Alert incorrectly describes mass 2 as moving right.
01-mass2-increases-pushes-mass1-incorrect-alert
02-mass2-increases-pushes-mass1-incorrect-alert

Incorrect alert when changing sphere is at edge pushing other mass away
incorrect-when-mass1-changes-at-edge

Incorrect alert: Same issue when increasing mass of Mass 2 when Mass 2 is at right edge
incorrect-mass2-at-edge-mass2-increase

Correct alert when unchanging sphere is at edge
Increasing mass of Mass 1 when Mass 2 is at right edge. In this case the alert is correctly describes mass 1 as moving left.
correct-mass1-moves-left-at-edge

Increasing mass of Mass 2 when Mass 1 is at left edge. Again, alert correctly describes mass 2 as moving right.
mass2-correct-alert-mass2-increase-mass1-at-left-edge
screen shot 2019-01-22 at 11 53 08 am

@terracoda
Copy link
Author

@zepumph, if you can get the description going in the correctly, great if not - do not worry.
Things are pretty good, at least movement is being described, just not quite the right direction yet.

@zepumph
Copy link
Member

zepumph commented Feb 20, 2019

This was a pretty big change. It seems to be working as expected now. Please review.

@zepumph
Copy link
Member

zepumph commented Feb 20, 2019

Sometimes it seems like there is a key press delay, where the "pushed mass" value text is one key press behind. But I can't get that to occur consistently, and it doesn't seem too distracting for right now. Let me know what you think.

@terracoda
Copy link
Author

@zepumph, I verified that all the alerts are firing correctly.
Shall we close this issue and start a new one to optimize the visual movement and better synchronizing the alerts about which mass is moving?

@terracoda
Copy link
Author

Actually, I will go ahead and do just that - start a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants