Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize visual movement when a mass change causes sphere movement #99

Closed
terracoda opened this issue Feb 20, 2019 · 2 comments
Closed
Assignees

Comments

@terracoda
Copy link

The edge case alerts were verified in #90, but @zepumph mentioned there is some work to optimize when and how the spheres move in the visual sim. Their movement is somewhat restricted by the snap-to behavior of the slider.

This sometimes creates some visual inconsistencies with the alerts that say it a mass moved when it visually didn't or vice-versa.

This might be a big issue to tackle.

@terracoda
Copy link
Author

The alerts for the edge cases (described movement caused by a mass change) work correctly on mass changes.

@zepumph, this issue is purely about visuals. Sometime there's movement and sometimes not. I am not sure what priority I should put on this issue.

zepumph added a commit to phetsims/gravity-force-lab that referenced this issue May 7, 2019
@zepumph
Copy link
Member

zepumph commented May 22, 2019

@terracoda and I think that this small discrepancy is fine for now. It's an issue with the visual design and how it used the snap-to locations. In this case we think that the the descriptions are actually more correct, although it doesn't align with the visual display. Closing for now, and we can revisit this if we find that this is an issue in interviews with users using auditory descriptions and the visual display.

@zepumph zepumph closed this as completed May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants