Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge case alerts for when position changes when changing a mass #135

Closed
terracoda opened this issue Dec 20, 2018 · 5 comments
Closed

Edge case alerts for when position changes when changing a mass #135

terracoda opened this issue Dec 20, 2018 · 5 comments
Assignees

Comments

@terracoda
Copy link
Contributor

@mbarlow12, we discussed the edge case alerts on Tuesday Dec 17. You mentioned they were working at some point. I am just opening this issue so we can track their implementation and any necessary changes if needed.

Here's edge case 1:

  • When increasing the mass of m1 with the Mass 1 slider, the increase pushes m2 a little to the right:
    • Changed mass value: {{200}} kilograms.
    • Alert: As mass {{gets bigger}} {{and moves {{m2}} {{right}}}} vectors {{get bigger}}, forces now {{1.021 506 micronewtons}}.

Here's edge case 2:

  • When increasing the mass of m1 with the Mass 1 slider, and m2 is at the right edge of the track, m1 moves left:
    • Changed mass value: {{250}} kilograms.
    • Alert: As mass {{gets bigger}} {{and moves {{left}}}} vectors {{get bigger}}, forces now {{3.604983 micronewtons}}.

More details in the design document under Edge Case Examples

@terracoda
Copy link
Contributor Author

@mbarlow12, let me know when these are ready to listen to, thanks.

@terracoda
Copy link
Contributor Author

@mbarlow12, keep in mind that when Constant Size checkbox is checked, these edge cases won't actually occur.

@zepumph zepumph changed the title Edge case alerts for when position cahnges when changing a mass Edge case alerts for when position changes when changing a mass Jan 15, 2019
@terracoda
Copy link
Contributor Author

@zepumph, I am adding screenshots of the sim with these alerts:

Edge case 1
m2-mass-increase--m1-moves-left

Edge case 2
m1-mass-increase-m1-moves-left

The alerts fire sometimes when there is no actual visual movement. There is some funny business of how the spheres move or move each other when they are right next to each other.

We may need to do some tweaking in the model to align actual movement and alerts, or make sure the visual movement is more consistent.

That said, I think @mbarlow12 has done a nice job implementing these edge case alerts.

@terracoda
Copy link
Contributor Author

@zepumph, please review this issue before closing. The alerts are implemented correctly in REGULAR, though as I said they may need some tweaking.

However, in BASICS, the alerts are NOT ALWAYS correct. Perhaps @mbarlow12 was not able to complete the work in that sim yet.

I am going to open a related issue in the BASICS repo, so we can track BASICS's issues there.

@zepumph
Copy link
Member

zepumph commented Jan 25, 2019

Alright I''ll see you over in phetsims/gravity-force-lab-basics#90 and phetsims/gravity-force-lab-basics#91. Closing

@zepumph zepumph closed this as completed Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants