-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edge case alerts for when position changes when changing a mass #135
Comments
@mbarlow12, let me know when these are ready to listen to, thanks. |
@mbarlow12, keep in mind that when Constant Size checkbox is checked, these edge cases won't actually occur. |
@zepumph, I am adding screenshots of the sim with these alerts: The alerts fire sometimes when there is no actual visual movement. There is some funny business of how the spheres move or move each other when they are right next to each other. We may need to do some tweaking in the model to align actual movement and alerts, or make sure the visual movement is more consistent. That said, I think @mbarlow12 has done a nice job implementing these edge case alerts. |
@zepumph, please review this issue before closing. The alerts are implemented correctly in REGULAR, though as I said they may need some tweaking. However, in BASICS, the alerts are NOT ALWAYS correct. Perhaps @mbarlow12 was not able to complete the work in that sim yet. I am going to open a related issue in the BASICS repo, so we can track BASICS's issues there. |
Alright I''ll see you over in phetsims/gravity-force-lab-basics#90 and phetsims/gravity-force-lab-basics#91. Closing |
@mbarlow12, we discussed the edge case alerts on Tuesday Dec 17. You mentioned they were working at some point. I am just opening this issue so we can track their implementation and any necessary changes if needed.
Here's edge case 1:
Here's edge case 2:
More details in the design document under Edge Case Examples
The text was updated successfully, but these errors were encountered: