-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possible for time readout to overlap control pannel #359
Comments
The string can get pretty close on my device too (macOS 10.15/latest Chrome) I think the reason the overlap doesn't occur on It seems like the maxWidth is probably a bit too large for the position of the button/string. We could either reduce the maxWidth by a few px or move the Clear button to the left by a few px. I don't really have a preference, so I'll leave it up to @samreid to decide. |
@arouinfar while I'm here, what do you think about changing the number readout text to use the same font as the stopwatch, so the numbers don't jump around? |
Sounds good to me @samreid. Please proceed. |
I switched to a monospace font for the text, and that helped. Next I tried different maxWidth values for the button and the readout, but it didn't look great. I tried aligning to the right and that seemed nicer to me, and easy to make sure they don't overlap. It looks like this: Is that an acceptable design? If so, please test it out thoroughly. |
@samreid the alignment looks good. I tested it out in master, and the string position looks good. I'll leave this open since it should be verified by QA in the next round of testing. |
This seems fixed in rc.2 |
For phetsims/qa#519. Seen on iPadOS 14, but doesn't seem to happen with
?stringTest=double
, just with the normal sim.If the counter for the time an object has been orbiting gets long enough, it can start to overlap with the control panel. Choose the Earth/Satellite combo to test, as it gets longer faster.
The text was updated successfully, but these errors were encountered: