-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RC-Lite test: Gravity and Orbits 1.2.0-rc.2 with PhET-iO #567
Comments
I published 1.2.0-rc.2 and added the URLs. I also moved it to "Active Tests". Reassigning to @KatieWoe so she is aware this is ready, and also assigning @ariel-phet in case any changes to priority/label/assignment are necessary. |
Should the accessibility section be removed? I don't think it has any of the listed features. |
Thanks, I removed the accessibility section. |
Can you clarify what you mean by the "orientation"? @pixelzoom or @zepumph or @jonathanolson can you please comment on the status of grayscale for disabled buttons? |
Tracked in phetsims/sun#658, I'm sorta out of the conversation, and I don't know if this blocks GAO publication. @ariel-phet, what steps need to be taken to make sure that GAO can be published? Currently it uses the "opacity" strategy from master/recent work in sun. Do we need to wait on a greyscale implementation, or talk to designers? |
@jonathanolson is working on filtering features (including grayscale) for scenery with high priority in phetsims/scenery#707 (comment). You'll have to ask @jonathanolson or @ariel-phet about when (and how) the scenery grayscale feature is expected to be added to sun buttons. |
It used to be centered under it's label. Now it is right justified. |
@KatieWoe the alignment of the Clear button was an intentional change, see phetsims/gravity-and-orbits#359 (comment). |
@jonathanolson indicated he is nearly ready to commit "grayscale" disabled support to master for phetsims/scenery#707 (comment), should I invalidate this test and create a new one once that is ready? |
@arouinfar recommends to pause RC testing on this version until @ariel-phet or @kathy-phet comments on whether we want grayscale in the upcoming release. Also, @jonathanolson can you comment on how modular/straightforward the changes are? Will they invalidate testing and require significant re-testing? |
After discussion with @arouinfar, @ariel-phet recommended halting this RC testing until we have the grayscale enabled components. I'll deprioritize and move it to another column in the project. |
@ariel-phet, @arouinfar, @kathy-phet, @KatieWoe, gravity-and-orbits/1.2.0-rc.2 is ready for RC-lite testing. This is for a client, and is one of their top priority projects. Document issues in https://github.com/phetsims/gravity-and-orbits/issues and link to this issue.
Assigning to @ariel-phet for prioritization.
General RC Test
What to Test
for a list of query parameters.)
spreadsheet and notify AR or AM if it not there.
there is a problem.
Focus and Special Instructions
This is an RC-lite test for the PhET-iO version, which will be delivered to the client once testing has passed. Prior
testing was completed in #519
Issues to Verify
These issues should have the "status:ready-for-qa" label. Check these issues off and close them if they are fixed.
Otherwise, post a comment in the issue saying that it wasn't fixed and link back to this issue. If the label is
"status:ready-for-review" or "status:fixed-pending-deploy" then assign back to the developer when done, even if fixed.
Link(s)
Links will be provided once the version has been built. There are still some blocks-publication or blocks-sim-publication
issues that need to be addressed first.
PhET-iO RC Test
What to Test
sure the simulation loads without crashing or throwing errors.
Here's the link to the previous wrapper.
?phetioDebug
on the Studio and State wrapper.Focus and Special Instructions
[Provide further instructions here. If you have any further tests you want done or specific platforms you want tested,
list them here. Any behaviors you want QA to pay special attention to should be listed here.]
Issues to Verify
These issues should have the "status:ready-for-qa" label. Check these issues off and close them if they are fixed.
Otherwise, post a comment in the issue saying that it wasn't fixed and link back to this issue. If the label is
"status:ready-for-review" or "status:fixed-pending-deploy" then assign back to the developer when done, even if fixed.
Link(s)
FAQs for QA Members
There are multiple tests in this issue... Which test should I do first?
Test in order! Test the first thing first, the second thing second, and so on.
How should I format my issue?
Here's a template for making issues:
Who should I assign?
We typically assign the developer who opened the issue in the QA repository.
My question isn't in here... What should I do?
You should:
The text was updated successfully, but these errors were encountered: