Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use inputEnabledProperty #144

Closed
2 tasks done
pixelzoom opened this issue Mar 2, 2021 · 8 comments
Closed
2 tasks done

Use inputEnabledProperty #144

pixelzoom opened this issue Mar 2, 2021 · 8 comments

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Mar 2, 2021

For #137 and #139...

Any Node with an input listener will need to have its inputEnabledProperty instrumented. These Nodes can be identified by searching for addInputListener in the graphing-quadratics code. That includes:

  • PointToolNode (point tools)
  • All subclasses of GQManipulator (manipulators)
@pixelzoom pixelzoom self-assigned this Mar 2, 2021
@pixelzoom
Copy link
Contributor Author

Slack:

Chris Malley 12:57 PM
Is inputEnabledProperty read for general use? I have a request to use it in Graphing Quadratics to support disabling of draggable things.

Kathy Perkins 12:56 PM
@pixelzoom - My impression was it wasn't ready yet.

Michael Kauzmann 12:28 PM
My optimistic hope is by the end of next week.

Kathy Perkins 2:24 PM
Graphing Quadratics can wait for the pickable to be resolved, after the work for ■■■ study is completed. Yes, we will push back the date after we have a sense of when we figure out when pickable alternative is identified.

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Mar 3, 2021

On hold and unassigned until phetsims/scenery#1116 is resolved and the PhET-iO team tells me that inputEnabledProperty is ready for use. @zepumph @samreid FYI.

@zepumph
Copy link
Member

zepumph commented Mar 3, 2021

Sounds good. This issue will be ready to go likely as part of phetsims/scenery#1158 though I can hold off on this repo is you would like. That issue is on hold until phetsims/scenery#1116 is sorted out.

@pixelzoom
Copy link
Contributor Author

This issue will be ready to go likely as part of phetsims/scenery#1158 though I can hold off on this repo is you would like.

FYI, there's no use of pickableProperty in this sim, which is the subject of phetsims/scenery#1158.

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Mar 3, 2021

@kathy-phet said:

Graphing Quadratics can wait for the pickable to be resolved

I interpret that to mean that we're going to wait to publish until inputEnabledProperty is ready, so labeling this issue as blocks-publication.

@zepumph
Copy link
Member

zepumph commented Mar 17, 2021

This is now ready for use. you can use inputEnabledPropertyPhetioInstrumented:true to instrument inputEnabledProperty instances in your sim.

@pixelzoom
Copy link
Contributor Author

Here's a description of the sim-specific inputEnabledProperty elements that were added in the above commits.

For point tools, there are 2 for each screen:

graphingQuadratics.*.view.leftPointToolNode.inputEnabledProperty
graphingQuadratics.*.view.rightPointToolNode.inputEnabledProperty

For manipulators:

graphingQuadratics.vertexFormScreen.view.vertexManipulator.inputEnabledProperty
graphingQuadratics.focusAndDirectrixScreen.view.focusManipulator.inputEnabledProperty
graphingQuadratics.focusAndDirectrixScreen.view.pointOnParabolaManipulator.inputEnabledProperty
graphingQuadratics.focusAndDirectrixScreen.view.vertexManipulator.inputEnabledProperty

@amanda-phet please review in master.

@amanda-phet
Copy link
Contributor

Looks like they are all there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants