Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review this sim in Studio #139

Closed
pixelzoom opened this issue Feb 18, 2021 · 5 comments
Closed

Review this sim in Studio #139

pixelzoom opened this issue Feb 18, 2021 · 5 comments

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Feb 18, 2021

Pre-requisite for #137...

In #137 (comment), @amanda-phet said:

@kathy-phet and I are thinking we should do another look at studio for this sim since there have likely been some changes to common code and studio practices since we last worked on this sim.

If we have changes to make to the featured list, we can do that with overrides. If anything else comes up, we will let you know @pixelzoom .

@amanda-phet
Copy link
Contributor

This is complete.

@pixelzoom let's schedule a meeting to review some of the questions and changes, and then I'll make GitHub issues for everything!

@amanda-phet amanda-phet assigned pixelzoom and unassigned kathy-phet Feb 27, 2021
@pixelzoom
Copy link
Contributor Author

@amanda-phet and I are going to Zoom on Tuesday, March 2 @ 11:00AM MST.

@amanda-phet amanda-phet removed their assignment Mar 3, 2021
@amanda-phet
Copy link
Contributor

Once #140 #141 #142 #143 #144 #145 #146 are complete, I still ned to go back to studio and feature some more elements.

  • graphingQuadratics.exploreScreen.view.equationAccordionBox.interactiveEquationNode.visibleProperty
  • the point tool nodes and their inputEnabledProperty IDs
  • point tool nodes quadraticProperty
  • manipulators and inputEnabledProperty

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Mar 3, 2021

All change requests except #144 have been addressed and are ready for review. #144 is on hold until the inputEnabledProperty is ready for general use.

Assigning this issue to @amanda-phet to follow up on #139 (comment).

amanda-phet added a commit that referenced this issue May 5, 2021
@amanda-phet
Copy link
Contributor

I believe this is complete after reviewing and updating overrides.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants