Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make visibleProperty read-only for AccordionBox titles #143

Closed
pixelzoom opened this issue Mar 2, 2021 · 3 comments
Closed

Make visibleProperty read-only for AccordionBox titles #143

pixelzoom opened this issue Mar 2, 2021 · 3 comments
Assignees
@amanda-phet
Labels
dev:phet-io status:ready-for-review

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Mar 2, 2021 •
edited
Loading

For #137 and #139...

For all AccordionBox titles, set visibleProperty phetioReadOnly: true
@pixelzoom pixelzoom self-assigned this Mar 2, 2021
@amanda-phet amanda-phet mentioned this issue Mar 3, 2021
Closed
pixelzoom added a commit that referenced this issue Mar 3, 2021
@pixelzoom
Make visibleProperty read-only for AccordionBox titles, #143
386d651
@pixelzoom
Copy link
Contributor Author

pixelzoom commented Mar 3, 2021 •
edited
Loading

There are 5 instances of visibleProperty that were changed to phetioReadOnly: true. Search for "AccordionBox.titleNode.visibleProperty", or see these elements:

graphingQuadratics.exploreScreen.view.equationAccordionBox.titleNode.visibleProperty
graphingQuadratics.exploreScreen.view.quadraticTermsAccordionBox.titleNode.visibleProperty
graphingQuadratics.standardFormScreen.view.equationAccordionBox.titleNode.visibleProperty
graphingQuadratics.vertexFormScreen.view.equationAccordionBox.titleNode.visibleProperty
graphingQuadratics.focusAndDirectrixScreen.view.equationAccordionBox.titleNode.visibleProperty

@pixelzoom
Copy link
Contributor Author

@amanda-phet ready for review in master or 1.2.0-dev.1.

@pixelzoom pixelzoom assigned amanda-phet and unassigned pixelzoom Mar 3, 2021
@amanda-phet
Copy link
Contributor

These all look good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amanda-phet amanda-phet

Labels
dev:phet-io status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pixelzoom @amanda-phet