Skip to content

Commit

Permalink
instrument inputEnabledProperty for point tools and manipulators, #144
Browse files Browse the repository at this point in the history
  • Loading branch information
pixelzoom committed Mar 17, 2021
1 parent 4379764 commit 4fa125c
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 6 deletions.
3 changes: 2 additions & 1 deletion js/common/view/GQManipulator.js
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@ class GQManipulator extends Manipulator {
haloAlpha: 0.15,

// phet-io
tandem: Tandem.REQUIRED
tandem: Tandem.REQUIRED,
inputEnabledPropertyPhetioInstrumented: true

}, options );

Expand Down
3 changes: 2 additions & 1 deletion js/common/view/PointToolNode.js
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@ class PointToolNode extends Node {

// phet-io
tandem: Tandem.REQUIRED,
phetioDocumentation: Tandem.PHET_IO_ENABLED ? pointTool.phetioDocumentation : null
phetioDocumentation: Tandem.PHET_IO_ENABLED ? pointTool.phetioDocumentation : null,
inputEnabledPropertyPhetioInstrumented: true

}, options );

Expand Down
4 changes: 2 additions & 2 deletions js/common/view/VertexManipulator.js
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@ class VertexManipulator extends GQManipulator {
coordinatesDecimals: GQConstants.VERTEX_DECIMALS,

// phet-io
phetioDocumentation: 'a manipulator for the vertex',
phetioReadOnly: true // because visibility is derived below
phetioDocumentation: 'manipulator for the vertex',
visiblePropertyOptions: { phetioReadOnly: true } // because visibility is derived below

}, options );

Expand Down
2 changes: 1 addition & 1 deletion js/focusanddirectrix/view/FocusManipulator.js
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ class FocusManipulator extends GQManipulator {

// phet-io
phetioDocumentation: 'manipulator for the focus',
phetioReadOnly: true // because visibility is derived below
visiblePropertyOptions: { phetioReadOnly: true } // because visibility is derived below

}, options );

Expand Down
2 changes: 1 addition & 1 deletion js/focusanddirectrix/view/PointOnParabolaManipulator.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ class PointOnParabolaManipulator extends GQManipulator {
coordinatesDecimals: GQConstants.POINT_ON_PARABOLA_DECIMALS,

// phet-io
phetioDocumentation: 'a manipulator for a point on the parabola'
phetioDocumentation: 'manipulator for a point on the parabola'

}, options );

Expand Down

0 comments on commit 4fa125c

Please sign in to comment.