Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implementation-notes.md #71

Closed
pixelzoom opened this issue Jan 30, 2024 · 2 comments
Closed

implementation-notes.md #71

pixelzoom opened this issue Jan 30, 2024 · 2 comments
Assignees
Labels
documentation Improvements or additions to documentation status:ready-for-review

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Jan 30, 2024

https://github.com/phetsims/faradays-electromagnetic-lab/blob/main/doc/implementation-notes.md

@pixelzoom pixelzoom added the documentation Improvements or additions to documentation label Jan 30, 2024
@pixelzoom pixelzoom self-assigned this Feb 27, 2024
pixelzoom added a commit that referenced this issue Mar 7, 2024
This was referenced Mar 13, 2024
pixelzoom added a commit to phetsims/magnets-and-electromagnets that referenced this issue Mar 13, 2024
pixelzoom added a commit to phetsims/magnet-and-compass that referenced this issue Mar 13, 2024
pixelzoom added a commit that referenced this issue Mar 14, 2024
pixelzoom added a commit that referenced this issue Mar 14, 2024
pixelzoom added a commit that referenced this issue Mar 14, 2024
pixelzoom added a commit that referenced this issue Mar 14, 2024
pixelzoom added a commit that referenced this issue Mar 14, 2024
pixelzoom added a commit that referenced this issue Mar 14, 2024
pixelzoom added a commit that referenced this issue Mar 14, 2024
pixelzoom added a commit that referenced this issue Mar 14, 2024
pixelzoom added a commit that referenced this issue Mar 14, 2024
pixelzoom added a commit that referenced this issue Mar 14, 2024
pixelzoom added a commit that referenced this issue Mar 14, 2024
pixelzoom added a commit that referenced this issue Mar 14, 2024
pixelzoom added a commit that referenced this issue Mar 14, 2024
pixelzoom added a commit that referenced this issue Mar 14, 2024
pixelzoom added a commit that referenced this issue Mar 14, 2024
pixelzoom added a commit that referenced this issue Mar 14, 2024
pixelzoom added a commit that referenced this issue Mar 14, 2024
pixelzoom added a commit that referenced this issue Mar 14, 2024
@pixelzoom
Copy link
Contributor Author

This is ready for code review, so assigning to @samreid and @matthew-blackman. Let me know what else would be helpful here.

@matthew-blackman
Copy link
Contributor

The examples provided in examples.md contain a nice overview of the customization options available via PhET-IO, as well as all sim preferences. Nice work! I went through the sim/doc and didn't find any notable omissions. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation status:ready-for-review
Projects
None yet
Development

No branches or pull requests

3 participants