Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

While paused, blocks jump out of beaker when beaker is moved #202

Closed
kellywurtz opened this issue Jan 28, 2019 · 17 comments
Closed

While paused, blocks jump out of beaker when beaker is moved #202

kellywurtz opened this issue Jan 28, 2019 · 17 comments
Assignees
Labels

Comments

@kellywurtz
Copy link

For phetsims/qa#268:

Test device:
Macbook

Operating System:
MacOS 10.14.2

Browser:
Chrome

Problem description:
While paused, dragging a beaker with blocks in it causes the beaker and blocks to be separated. The beaker jumps to the side while the blocks stay in place.

Steps to reproduce:

  • Pause sim
  • Drag block (or two) into either beaker.
  • Move beaker.

Screenshots:
efac_doesnotmoveasgroup

@KatieWoe
Copy link
Contributor

Likely related to, or even the same as #196

@jbphet
Copy link
Contributor

jbphet commented Jan 28, 2019

@chrisklus and I talked about disallowing dragging of blocks and beakers while paused, and I just discussed this with @ariel-phet, and he's cool with it. He just suggests that we make the pause button a bit smaller to call more attention to the change of states. We decided to essentially "split the difference" between the size of the play button and the step button.

@arouinfar
Copy link
Contributor

@jbphet @ariel-phet I was discussing this a bit with @chrisklus, and I think it's a bit unprecedented to make something unpickable when paused. This may also have some unintended consequences for keyboard nav later down the line. I am fine with this solution for 1.0, but I don't think it's ideal.

I think a more natural alternative would be to simply unpause the sim when the user starts dragging blocks or beakers. We did this with the wrench in Wave on a String. If the sim is paused, dragging the wrench will unpause the sim.

@ariel-phet
Copy link

@arouinfar agreed, would be good to have a better solution in place for 1.1

@ariel-phet ariel-phet removed their assignment Jan 28, 2019
@chrisklus
Copy link
Contributor

@arouinfar @ariel-phet it's equally easy to 1) make the beakers and blocks unpickable while the sim is paused, or 2) make the sim resume playing when when a beaker or block is grabbed.

Sounds like @arouinfar is leaning towards the latter, what is your preference @ariel-phet?

@chrisklus chrisklus assigned ariel-phet and unassigned jbphet Jan 28, 2019
@ariel-phet
Copy link

@chrisklus I am fine with (2)

@ariel-phet ariel-phet removed their assignment Jan 28, 2019
@chrisklus
Copy link
Contributor

@ariel-phet cool, thanks. Would you still like the pause button to be smaller, and if so, should the pause button on the second screen match that size?

@ariel-phet
Copy link

@chrisklus yes, I think a bit smaller would be good, and yes, match the second screen. I think it generally looks good when then button appears to "grow" in case someone hit it by accident.

@ariel-phet ariel-phet assigned chrisklus and unassigned ariel-phet and chrisklus Jan 28, 2019
@arouinfar
Copy link
Contributor

I think it generally looks good when then button appears to "grow" in case someone hit it by accident.

Ah, I just now understood what @jbphet meant by:

He just suggests that we make the pause button a bit smaller to call more attention to the change of states.

@ariel-phet I'd have to disagree. While it's true that some sims do have a play button that is larger than its corresponding pause, I have always found it to look a bit strange. Given the placement of the playback buttons in EFAC, I'm not particularly worried about accidental presses. I'd rather not include this feature in 1.0, but I will open a separate issue for discussion for 1.1+.

@chrisklus please proceed with option (2), and unpause the sim when the blocks or beakers are moved. For now, let's leave the playback buttons alone.

@chrisklus
Copy link
Contributor

Implemented, could @KatieWoe, @arouinfar, or @ariel-phet try this out please.

@KatieWoe
Copy link
Contributor

I'm ok with this

@arouinfar
Copy link
Contributor

Looks good @chrisklus.

@KatieWoe
Copy link
Contributor

KatieWoe commented Mar 4, 2019

Found a case during phetsims/qa#293 that may cause problems for this solution. Multitouch. If you pause the sim while still holding an object, you will still be able to drag that object around while the sim remains paused. Easiest to do on a touch screen like an iPad. Haven't seen any issues arise from it yet, and it is a bit more of an edge case. So feel free to close unless you think something more should be done.
edgecaseworkaround

@KatieWoe KatieWoe reopened this Mar 4, 2019
@chrisklus
Copy link
Contributor

@KatieWoe I'm not too worried about this. Once the user lets go, as soon as another block or beaker is touched, the sim resumes, right?

@KatieWoe
Copy link
Contributor

KatieWoe commented Mar 4, 2019

@chrisklus Yes

@chrisklus
Copy link
Contributor

@KatieWoe cool, thanks. I'm okay with closing but let's wait for more opinions first.

@ariel-phet
Copy link

Yes, I think OK to close. We generally do not worry too much about some of these multitouch edge cases unless they have the potential to wreak havoc pedagogically or crash the sim horribly. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants