Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thermometer attached but not reading #195

Closed
KatieWoe opened this issue Jan 25, 2019 · 10 comments
Closed

Thermometer attached but not reading #195

KatieWoe opened this issue Jan 25, 2019 · 10 comments

Comments

@KatieWoe
Copy link
Contributor

For phetsims/qa#268. Found while making a gif for another issue. Unsure how to reproduce at the moment.
The thermometer is attached to the beaker and is moving along with it. However, it is not the correct color and is not displaying the temperature.
https://drive.google.com/file/d/1kgYv_obHYBZT8ImxC4JrFpPYeLHSq71Q/view?usp=sharing

@ariel-phet
Copy link

@KatieWoe assigning to you until reproducible steps can be found.

@chrisklus
Copy link
Contributor

Yeah, I've been trying to reproduce for a while but with no luck. 10 points to anyone who can.

@phet-steele
Copy link

  1. Fresh load on Intro screen.
  2. Pause
  3. Grab a thermometer out of its box and just put it to the side for now.
  4. Take a beaker (although I find this WAY easier to do with a block) and place it over the thermometer box in the top left.
  5. Take your thermometer from step three and try to put it back into its box.

May take some tries (although I get it first try every time with a block) but when you do it correctly, it will look like the thermometer has returned to its box. This is evidenced by it being layered behind your beaker/block.

  1. Drag your beaker/block away from the box and the thermometer will snap to your object and not read temperature.

@phet-steele phet-steele assigned chrisklus and ariel-phet and unassigned KatieWoe Jan 26, 2019
@ariel-phet
Copy link

OK, I reproduced this bug. Marking as deferred.

This is odd and should be fixed, but I think it is uncommon enough to fly for 1.0

In addition, clicking the thermometer immediately fixes the issue (and feels very natural to do when it is layered behind the block).

@chrisklus
Copy link
Contributor

Wow, nice @phet-steele!

@KatieWoe
Copy link
Contributor Author

This is actually slightly different from what I'm seeing. I just figured out what happened and its a bit more concerning @ariel-phet. Also not sure how it took me so long to reproduce.
Steps:

  1. Move a thermometer onto a beaker
  2. Hit the orange reset button
  3. Pick up the beaker from step one.

thermometeronthebeakersolved

@ariel-phet
Copy link

@chrisklus --not the bug @phet-steele found, but the bug @KatieWoe found in #195 (comment) seems worthy of fixing if possible. Seems something is not getting reset properly and the bug is quite easy to reproduce following the steps.

@chrisklus
Copy link
Contributor

Should be fixed, @KatieWoe please test.

@KatieWoe
Copy link
Contributor Author

This does seem fixed on master

@chrisklus
Copy link
Contributor

Good deal, thanks @KatieWoe. Since that is fixed, and the bug described in #195 (comment) is no longer possible since dragging model elements on pause was disabled in #202, I'm going to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants