Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev test: Energy Forms and Changes 1.1.0-dev.4 #293

Closed
4 tasks done
chrisklus opened this issue Mar 4, 2019 · 12 comments
Closed
4 tasks done

Dev test: Energy Forms and Changes 1.1.0-dev.4 #293

chrisklus opened this issue Mar 4, 2019 · 12 comments
Assignees
Labels
QA:dev-test Dev test before an RC

Comments

@chrisklus
Copy link

chrisklus commented Mar 4, 2019

@jbphet, @arouinfar, @KatieWoe, @ariel-phet, energy-forms-and-changes/1.1.0-dev.4 is ready for dev testing. Please document issues in https://github.com/phetsims/energy-forms-and-changes/issues and link to this issue.

Assigning @ariel-phet for prioritization.

General Dev Test

What to Test

  • Click every single button.
  • If there is sound, make sure it works.
  • Make sure you can't lose anything.
  • Play with the sim normally.
  • Try to break the sim.

Focus and Special Instructions

We've added an alternative algorithm for distributing the energy chunks within their blocks and beakers. It's faster and meant to replace the usual repulsive algorithm on slow devices. We'd like to make sure that it's kicking in when it should on slower devices like Tycho and Jemison, and is not kicking in on normal/fast devices. See the query param below to familiarize yourself with its behavior.

Query params:

To view the alternative energy chunk distribution algorithm (on any device, regardless of speed), add the query param ecDistribution=spiral.

You can add speed controls to the first screen with the query param showSpeedControls. This is useful for testing, but we are not looking for issues caused only by fast forward.

If you're tired of having to manually hold the burners on the intro screen, you can make them sticky with the query param stickyBurners.

General Dev Test Platforms

  • Latest macOS, Chrome and Safari
  • Latest iOS, Safari
  • Windows 10, all browsers
  • Latest Chrome OS, Chrome

Link


FAQs for QA Members
There are multiple tests in this issue... Which test should I do first?

Test in order! Test the first thing first, the second thing second, and so on.


How should I format my issue?

Here's a template for making issues:

  <b>Test Device</b>

  blah

  <b>Operating System</b>

  blah

  <b>Browser</b>

  blah

  <b>Problem Description</b>

  blah

  <b>Steps to Reproduce</b>

  blah

  <b>Visuals</b>

  blah

  <details>
  <summary><b>Troubleshooting Information</b></summary>

  blah

  </details>

Who should I assign?

We typically assign the developer who opened the issue in the QA repository.


My question isn't in here... What should I do?

You should:

  1. Consult the QA Book.
  2. Google it.
  3. Ask Katie.
  4. Ask a developer.
  5. Google it again.
  6. Cry.


@chrisklus chrisklus added the QA:dev-test Dev test before an RC label Mar 4, 2019
@ariel-phet ariel-phet assigned KatieWoe and unassigned ariel-phet Mar 4, 2019
@KatieWoe
Copy link
Contributor

KatieWoe commented Mar 4, 2019

Here is a gif of how the energy chunks move without the spiral:
normalmovementofenergy
Here is a gif of how the energy chunks move in the spiral:
fancycircleenergymovement

@KatieWoe
Copy link
Contributor

KatieWoe commented Mar 5, 2019

I saw the sim go to spiral once in edge, but upon every other load so far use the default behavior.

@KatieWoe
Copy link
Contributor

KatieWoe commented Mar 5, 2019

Edge also has brief periods of lags and graphical flashes, but overall I would say it is acceptable for the platform. @jbphet let me know if you want further investigation on this.

@ghost
Copy link

ghost commented Mar 5, 2019

Windows 7 + IE Performance

  • Without ecDistribution=spiral: FPS ~ 11 while chunks float up.
  • With ecDistribution=spiral: FPS ~ 30 while chunks float up.

Visually, ecDistribution=spiral is a significant improvement.

@ghost
Copy link

ghost commented Mar 5, 2019

Windows 7 + Chrome Performance

  • Without ecDistribution=spiral: FPS ~ 55 while chunks float up.
  • With ecDistribution=spiral: FPS ~ 60 while chunks float up.

Looks like the bad performance on Windows 7 + IE is due to IE, not Windows 7.

@ghost
Copy link

ghost commented Mar 5, 2019

Forgot to mention you, @jbphet.

@ghost
Copy link

ghost commented Mar 5, 2019

iOS 11 + Safari Performance

  • Without ecDistribution=spiral: FPS ~ 9 while chunks float up.
  • With ecDistribution=spiral: FPS ~ 14 while chunks float up.

Without ecDistribution=spiral doesn't actually look that bad despite the low frame rate. With ecDistribution=spiral is a slight improvement.

@ghost
Copy link

ghost commented Mar 6, 2019

Feynman (ChromeOS 73.0.3683.32) Performance

  • Without ecDistribution=spiral: FPS ~ 5 while chunks float up.
  • With ecDistribution=spiral: FPS ~ 7 while chunks float up.

Without or without, the performance is pretty bad.

Feynman is enrolled in the Chrome Beta, so the Chrome version is newer than regular Chrome.

Performance on Chadwick (another Chromebook test device we have) is much better than performance on Feynman. Chadwick is not enrolled in the Chrome Beta.

@ghost
Copy link

ghost commented Mar 6, 2019

Checked the following low performance platforms:

  • Windows 7 + IE,
  • Windows 7 + Firefox,
  • Windows 7 + Chrome,
  • iOS 9 + Safari,
  • iOS 10 + Safari,
  • iOS 11 + Safari,
  • macOS 10.10 + Safari, and
  • ChromeOS

Posted a comment in this issue if I thought there was anything noteworthy.

@chrisklus, @jbphet, let me know if there are any other platforms you'd like tested.

@ghost
Copy link

ghost commented Mar 6, 2019

I think QA is done unless @KatieWoe has anything else she'd like to test.

@KatieWoe
Copy link
Contributor

KatieWoe commented Mar 6, 2019

I agree, this looks good. Thanks @lmulhall-phet
QA is done

@KatieWoe KatieWoe assigned chrisklus and unassigned KatieWoe Mar 6, 2019
@chrisklus
Copy link
Author

Thanks everyone, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA:dev-test Dev test before an RC
Projects
None yet
Development

No branches or pull requests

3 participants