-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tea kettle preloaded energy chunks have a gap #178
Comments
This behavior is also present in the Java sim. |
This is fixed, closing. |
This can happen to a minor degree if you switch tabs and come back. For phetsims/qa#293 |
Second unintended consequence: I noticed that when turning on energy chunks you can get a situation where chunks appear to be coming from an empty bucket. |
#178 (comment) has been fixed by capping the max dt for a time step. |
#178 (comment) has also been fixed. Now, if the burner is on when chunks are being preloaded, the chunks originate from the burner, but it the burner is off when they're being preloaded, then they originate from the tea kettle. |
@KatieWoe could you please verify my changes above on master and close if all looks good? |
I would say this looks pretty good on master. |
Looks good in 1.1.0-rc.2 |
Found when fixing #176.
After the tea kettle is steaming and then energy chunks are turned on, there is a gap between the initial stream of chunks and the chunks that follow out of the burner.
@arouinfar and I think that the preloaded energy chunks should originate from the burner instead of the center of the tea kettle (which would close the gap), but this is lower priority than other issues.
The text was updated successfully, but these errors were encountered: