Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC test: Energy Forms and Changes 1.1.0-rc.2 #298

Closed
3 of 4 tasks
chrisklus opened this issue Mar 15, 2019 · 9 comments
Closed
3 of 4 tasks

RC test: Energy Forms and Changes 1.1.0-rc.2 #298

chrisklus opened this issue Mar 15, 2019 · 9 comments
Assignees

Comments

@chrisklus
Copy link

chrisklus commented Mar 15, 2019

@jbphet, @arouinfar, @KatieWoe, @ariel-phet, energy-forms-and-changes/1.1.0-rc.2 is ready for RC testing (Despite rc.2, this is really the first RC that we're testing because of a build server error). Please document issues in https://github.com/phetsims/energy-forms-and-changes/issues and link to this issue.

Assigning to @ariel-phet for prioritization.

General RC Test

What to Test

  • Click every single button.
  • Test all possible forms of input.
    • Test all mouse/trackpad inputs.
    • Test all touchscreen inputs.
  • If there is sound, make sure it works.
  • Make sure you can't lose anything.
  • Play with the sim normally.
  • Try to break the sim.
  • Test all query parameters on all platforms. (See QA Book for a list of query parameters.)
  • Download HTML on Chrome and iOS.
  • Make sure the iFrame version of the simulation is working as intended on all platforms.
  • Make sure the XHTML version of the simulation is working as intended on all platforms.
  • Complete the test matrix.
  • Don't forget to make sure the sim works with Legends of Learning.
  • Check this LoL spreadsheet and notify AR if it not there.
  • If this is rc.1 please do a memory test.
  • When making an issue, check to see if it was in a previously published version

Query params:

To view the alternative energy chunk distribution algorithm (on any device, regardless of speed), add the query param ecDistribution=spiral.

You can add speed controls to the first screen with the query param showSpeedControls. This is useful for testing, but we are not looking for issues caused only by fast forward.

If you're tired of having to manually hold the burners on the intro screen, you can make them sticky with the query param stickyBurners.

Issues to Verify

We've added an alternative algorithm for distributing the energy chunks within their blocks and beakers. It's faster and meant to replace the usual repulsive algorithm on slow devices. We'd like to make sure that it's kicking in when it should on slower devices like Tycho and Jemison, and is not kicking in on normal/fast devices. See the query param above to familiarize yourself with its behavior.

These issues should have the "status:fixed-pending-testing" label. Check these issues off and close them if they are fixed. Otherwise, post a comment in the issue saying that it wasn't fixed.

Link(s)


FAQs for QA Members
There are multiple tests in this issue... Which test should I do first?

Test in order! Test the first thing first, the second thing second, and so on.


How should I format my issue?

Here's a template for making issues:

  <b>Test Device</b>

  blah

  <b>Operating System</b>

  blah

  <b>Browser</b>

  blah

  <b>Problem Description</b>

  blah

  <b>Steps to Reproduce</b>

  blah

  <b>Visuals</b>

  blah

  <details>
  <summary><b>Troubleshooting Information</b></summary>

  blah

  </details>

Who should I assign?

We typically assign the developer who opened the issue in the QA repository.


My question isn't in here... What should I do?

You should:

  1. Consult the QA Book.
  2. Google it.
  3. Ask Katie.
  4. Ask a developer.
  5. Google it again.
  6. Cry.


@KatieWoe
Copy link
Contributor

Memory test results:
Start: 30.7
1 min: 40.2
2 min: 42.2
3 min: 41.8
4 min: 42.2
5 min: 43.8
6 min: 43.0
7 min: 44.1
8 min: 44.1
9 min: 43.6
10 min: 43.7

@jonathanolson
Copy link
Contributor

This release branch had patches related to phetsims/chipper#720 applied since the last RC. Since this just adds a phetmarks dependency, I believe another RC wouldn't be needed since it should not significantly affect the sim (as long as it builds).

@KatieWoe
Copy link
Contributor

KatieWoe commented Apr 3, 2019

QA is done

@KatieWoe KatieWoe assigned jbphet and chrisklus and unassigned KatieWoe Apr 3, 2019
@mattpen
Copy link
Contributor

mattpen commented Apr 26, 2019

This branch was patched as part of the batch maintenance release in phetsims/chipper#746. This should just have added a .gz file to the build artifacts.

@chrisklus
Copy link
Author

Patched issue https://github.com/phetsims/phet-ios-app/issues/484 on this release branch.

@pixelzoom
Copy link
Contributor

As noted in phetsims/energy-forms-and-changes#253, the 1.1 branch is likely to be abandoned. So this issue can probably be close without completing the RC test. Assigning to @chrisklus and @jbphet to verify.

@jbphet
Copy link
Contributor

jbphet commented Aug 1, 2019

@pixelzoom said:

[T]he 1.1 branch is likely to be abandoned.

This may well happen, but it hasn't been decided yet, see phetsims/energy-forms-and-changes#253 (comment).

@jbphet
Copy link
Contributor

jbphet commented Aug 5, 2019

I have fixed an issue that I believe was blocking this release -phetsims/energy-forms-and-changes#238 - and I'm not aware of any others, but I believe @chrisklus was riding herd on this, so I'll turn it over to him. If there are no other blocking issues, the 1.1 release can go out.

@jbphet jbphet assigned chrisklus and unassigned jbphet Aug 29, 2019
@chrisklus
Copy link
Author

We've moved on to 1.2 for this sim, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants