-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RC test: Energy Forms and Changes 1.1.0-rc.2 #298
Comments
Memory test results: |
This release branch had patches related to phetsims/chipper#720 applied since the last RC. Since this just adds a phetmarks dependency, I believe another RC wouldn't be needed since it should not significantly affect the sim (as long as it builds). |
QA is done |
This branch was patched as part of the batch maintenance release in phetsims/chipper#746. This should just have added a .gz file to the build artifacts. |
Patched issue https://github.com/phetsims/phet-ios-app/issues/484 on this release branch. |
As noted in phetsims/energy-forms-and-changes#253, the 1.1 branch is likely to be abandoned. So this issue can probably be close without completing the RC test. Assigning to @chrisklus and @jbphet to verify. |
@pixelzoom said:
This may well happen, but it hasn't been decided yet, see phetsims/energy-forms-and-changes#253 (comment). |
I have fixed an issue that I believe was blocking this release -phetsims/energy-forms-and-changes#238 - and I'm not aware of any others, but I believe @chrisklus was riding herd on this, so I'll turn it over to him. If there are no other blocking issues, the 1.1 release can go out. |
We've moved on to 1.2 for this sim, closing. |
@jbphet, @arouinfar, @KatieWoe, @ariel-phet, energy-forms-and-changes/1.1.0-rc.2 is ready for RC testing (Despite rc.2, this is really the first RC that we're testing because of a build server error). Please document issues in https://github.com/phetsims/energy-forms-and-changes/issues and link to this issue.
Assigning to @ariel-phet for prioritization.
General RC Test
What to Test
Query params:
To view the alternative energy chunk distribution algorithm (on any device, regardless of speed), add the query param
ecDistribution=spiral
.You can add speed controls to the first screen with the query param
showSpeedControls
. This is useful for testing, but we are not looking for issues caused only by fast forward.If you're tired of having to manually hold the burners on the intro screen, you can make them sticky with the query param
stickyBurners
.Issues to Verify
We've added an alternative algorithm for distributing the energy chunks within their blocks and beakers. It's faster and meant to replace the usual repulsive algorithm on slow devices. We'd like to make sure that it's kicking in when it should on slower devices like Tycho and Jemison, and is not kicking in on normal/fast devices. See the query param above to familiarize yourself with its behavior.
alternative distribution
falling energy chunks
clipping back of block
teapot energy
These issues should have the "status:fixed-pending-testing" label. Check these issues off and close them if they are fixed. Otherwise, post a comment in the issue saying that it wasn't fixed.
Link(s)
FAQs for QA Members
There are multiple tests in this issue... Which test should I do first?
Test in order! Test the first thing first, the second thing second, and so on.
How should I format my issue?
Here's a template for making issues:
Who should I assign?
We typically assign the developer who opened the issue in the QA repository.
My question isn't in here... What should I do?
You should:
The text was updated successfully, but these errors were encountered: