Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

?stringTest=double ammeter readout expands over vertices #419

Closed
phet-steele opened this issue Oct 17, 2017 · 7 comments
Closed

?stringTest=double ammeter readout expands over vertices #419

phet-steele opened this issue Oct 17, 2017 · 7 comments
Assignees

Comments

@phet-steele
Copy link
Contributor

@samreid I don't think this is a big deal, but it looks odd. If you look below, the readout is expanded over the vertices slightly. This is also true of the image in the sensor tool box. Not so sure it even needs to expand that far?

screen shot 2017-10-17 at 2 58 03 pm

Seen on macOS 10.12.6 Chrome. For phetsims/qa/issues/55.
URL: https://www.colorado.edu/physics/phet/dev/html/circuit-construction-kit-dc/1.0.0-rc.1/circuit-construction-kit-dc_en.html?stringTest=double
Version: 1.0.0-rc.1 2017-10-17 18:05:58 UTC
Features missing: touch
Flags: pixelRatioScaling
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.100 Safari/537.36
Language: en-US
Window: 1920x1014
Pixel Ratio: 2/1
WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium)
GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium)
Vendor: WebKit (WebKit WebGL)
Vertex: attribs: 16 varying: 32 uniform: 1024
Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 80)
Max viewport: 16384x16384
OES_texture_float: true
Dependencies JSON: {"assert":{"sha":"928741cf","branch":"HEAD"},"axon":{"sha":"8a8ff7d2","branch":"HEAD"},"babel":{"sha":"0b5a4452","branch":"master"},"brand":{"sha":"cfca902d","branch":"HEAD"},"chipper":{"sha":"b8a3c09a","branch":"HEAD"},"circuit-construction-kit-common":{"sha":"11736e99","branch":"HEAD"},"circuit-construction-kit-dc":{"sha":"5cbdc391","branch":"HEAD"},"dot":{"sha":"84bc5146","branch":"HEAD"},"joist":{"sha":"92b186e2","branch":"HEAD"},"kite":{"sha":"067109a8","branch":"HEAD"},"phet-core":{"sha":"054b2d6d","branch":"HEAD"},"phetcommon":{"sha":"b13138d2","branch":"HEAD"},"query-string-machine":{"sha":"c74e454e","branch":"HEAD"},"scenery":{"sha":"c9c3052a","branch":"HEAD"},"scenery-phet":{"sha":"124c1c25","branch":"HEAD"},"sherpa":{"sha":"0d590744","branch":"HEAD"},"sun":{"sha":"082fee37","branch":"HEAD"},"tandem":{"sha":"98e9917c","branch":"HEAD"},"twixt":{"sha":"a2eaa10a","branch":"HEAD"}}

@phet-steele
Copy link
Contributor Author

@samreid....I'm not entirely sure if the readout has a maxWidth 😄
screen shot 2017-10-17 at 3 07 24 pm

@phet-steele
Copy link
Contributor Author

I suppose it is also important to note that you cannot see electrons passing through?

@samreid
Copy link
Member

samreid commented Oct 24, 2017

Fix pushed to master and needs to be merged into the RC for RC.2.

@samreid
Copy link
Member

samreid commented Oct 24, 2017

Merged and ready for testing in next rc.

@samreid
Copy link
Member

samreid commented Oct 27, 2017

Will be ready for RC testing in phetsims/qa#59

@phet-steele
Copy link
Contributor Author

Looks great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants