-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shorten the pH probe #160
Comments
The probe length has been shortened from 50 to 40, and drag range adjusted accordingly. (I tried 35 and it looked too short.) See screenshots below comparing initial location before and after this change, shown with @KatieWoe @arouinfar please review in master and verify that this addresses the usability concern. Before (published version 1.2.19) After (master) |
@pixelzoom the screenshot with shorter length looks good to me. Since the original motivation for this change related to a pesky iPhone menu, and I don't have an iPhone, I'll defer to @KatieWoe |
Still occurs but much easier to get around now |
I could make the probe even shorter, but I think that starts to compromise things. @kathy-phet @KatieWoe let me know what you think. And again... It would be really nice to have some standards for margins, since this is a general problem. |
I don't think it's necessary. Like I said, it is much better, and being shorter could cause more problems. We would probably have to move too far from the edge of the screen for this to stop happening all together. This distance seems to prevent major disruption/feels better to me, so my vote is stop here. @kathy-phet to make final decision though. |
@kathy-phet reminder that this is awaiting your review. |
I'm going to go with @KatieWoe's opinion (which I agree with), and mark this as "fixed-awaiting-deploy". |
The pH probe is shorter. Reassigning @pixelzoom. |
Thanks @liam-mulhall. Closing. |
... as describe in #158 (comment).
The pH probe's initial location is close to the top of the screen. On iPhone this can cause the iPhone menu to be dragged down instead of the pH meter. So we're going to shorten the probe, move the pH meter's initial location down, and adjust the drag bounds accordingly.
The text was updated successfully, but these errors were encountered: