Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

faucet control is too close to top of screen #260

Closed
pixelzoom opened this issue Jul 31, 2019 · 3 comments
Closed

faucet control is too close to top of screen #260

pixelzoom opened this issue Jul 31, 2019 · 3 comments
Assignees

Comments

@pixelzoom
Copy link
Contributor

Noted during code review #247

The faucet control is very close to the top of the layoutBounds, see screenshot below with ?dev. I would expect this to have a problem similar to what we just fixed in phetsims/acid-base-solutions#160. And we have identified that margins, particularly at the top of the screen, are a general problem, see phetsims/joist#571.

So perhaps this should be addressed sooner, rather than later.

screenshot_1296

@arouinfar
Copy link
Contributor

The FaucetNode shooter uses a horizontal swipe, so the interaction is a bit different than phetsims/acid-base-solutions#160. I believe the problem with ABS was that the vertical swipe opened an iPhone menu. @KatieWoe can you test on an iPhone and see if you have any issue with the faucet? Bear in mind that the touch areas will be dilated in phetsims/scenery-phet#521.

@arouinfar arouinfar assigned KatieWoe and unassigned arouinfar Jul 31, 2019
@KatieWoe
Copy link
Contributor

I am having an issue using the faucet on master. No sure why, or why it wasn't caught the last time around.

@arouinfar
Copy link
Contributor

I followed up with @KatieWoe, and the issue on the iPhone is the small touch area, particularly in portrait mode. The iPhone menu is not being unintentionally summoned by the horizontal swipe, so phetsims/scenery-phet#521 should be sufficient to address @KatieWoe's concern in #260 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants