You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The faucet control is very close to the top of the layoutBounds, see screenshot below with ?dev. I would expect this to have a problem similar to what we just fixed in phetsims/acid-base-solutions#160. And we have identified that margins, particularly at the top of the screen, are a general problem, see phetsims/joist#571.
So perhaps this should be addressed sooner, rather than later.
The text was updated successfully, but these errors were encountered:
The FaucetNode shooter uses a horizontal swipe, so the interaction is a bit different than phetsims/acid-base-solutions#160. I believe the problem with ABS was that the vertical swipe opened an iPhone menu. @KatieWoe can you test on an iPhone and see if you have any issue with the faucet? Bear in mind that the touch areas will be dilated in phetsims/scenery-phet#521.
I followed up with @KatieWoe, and the issue on the iPhone is the small touch area, particularly in portrait mode. The iPhone menu is not being unintentionally summoned by the horizontal swipe, so phetsims/scenery-phet#521 should be sufficient to address @KatieWoe's concern in #260 (comment).
Noted during code review #247
The faucet control is very close to the top of the layoutBounds, see screenshot below with
?dev
. I would expect this to have a problem similar to what we just fixed in phetsims/acid-base-solutions#160. And we have identified that margins, particularly at the top of the screen, are a general problem, see phetsims/joist#571.So perhaps this should be addressed sooner, rather than later.
The text was updated successfully, but these errors were encountered: