-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RC Spot Check: Molecules and Light 1.5.0-rc.3 #520
Comments
|
@jessegreenberg are these platforms ok? |
Can we change Win 10 IE to Win 10 Edge? Otherwise this looks great. |
I reviewed the list of blocks-publication issues as of today and phetsims/query-string-machine#42 is the only one that would potentially impact this release. @kathy-phet @ariel-phet can you please comment on whether that issue should block the release of this sim? Should the |
Over slack @kathy-phet said
|
Concurrent top priority with #514 and #515 (particularly since a spot check) @jessegreenberg might want to consider cherrypicking the fix in: phetsims/joist#645 |
In phetsims/joist#645 I decided not to cherry-pick changes for that issue because MAL is a single screen sim and does not display the home screen. |
QA is done. |
OK thank you @KatieWoe and team - we are ready for deploy-production and this issue can be closed. |
@KatieWoe, @ariel-phet, @emily-phet, @terracoda @Matthew-Moore240 molecules-and-light/1.5.0-rc.3 is ready for an RC spot check. Please document issues in https://github.com/phetsims/molecules-and-light issues and link to this issue.
This build comes right after rc.2 in #513. Only a few issues needed to be addressed and changes for each were minimal. A full RC is not necessary, but a spot check for each issues and overall test to make sure that things generally look OK would be helpful.
Simulation Links
Issues to Verify
Finally, please make sure that global hotkeys and hotkeys for zoom commands work as expected on a number of different platforms as that was the common area for each of the above issues. Otherwise, the sim was unchanged.
Assigning to @ariel-phet to provide priority for this issue.
The text was updated successfully, but these errors were encountered: