Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC Spot Check: Molecules and Light 1.5.0-rc.3 #520

Closed
4 tasks done
jessegreenberg opened this issue Jul 21, 2020 · 9 comments
Closed
4 tasks done

RC Spot Check: Molecules and Light 1.5.0-rc.3 #520

jessegreenberg opened this issue Jul 21, 2020 · 9 comments
Assignees

Comments

@jessegreenberg
Copy link
Contributor

jessegreenberg commented Jul 21, 2020

@KatieWoe, @ariel-phet, @emily-phet, @terracoda @Matthew-Moore240 molecules-and-light/1.5.0-rc.3 is ready for an RC spot check. Please document issues in https://github.com/phetsims/molecules-and-light issues and link to this issue.

This build comes right after rc.2 in #513. Only a few issues needed to be addressed and changes for each were minimal. A full RC is not necessary, but a spot check for each issues and overall test to make sure that things generally look OK would be helpful.

Simulation Links

Issues to Verify

Finally, please make sure that global hotkeys and hotkeys for zoom commands work as expected on a number of different platforms as that was the common area for each of the above issues. Otherwise, the sim was unchanged.

Assigning to @ariel-phet to provide priority for this issue.

@KatieWoe
Copy link
Contributor

KatieWoe commented Jul 21, 2020

  • Win 10 chrome w/ Jaws
  • Win 10 firefox w/ NVDA
  • Win 10 edge

  • macOS 10.15 Chrome
  • macOS 10.15 Safari w/ VoiceOver

  • Mac 10.12 Safari

  • ChromeOS
  • iPadOS 13 w/ VO

@KatieWoe
Copy link
Contributor

@jessegreenberg are these platforms ok?

@jessegreenberg
Copy link
Contributor Author

Can we change Win 10 IE to Win 10 Edge? Otherwise this looks great.

@jessegreenberg
Copy link
Contributor Author

I reviewed the list of blocks-publication issues as of today and phetsims/query-string-machine#42 is the only one that would potentially impact this release.

@kathy-phet @ariel-phet can you please comment on whether that issue should block the release of this sim? Should the ?screens query parameter have a graceful warning if the value is invalid for single screen sims?

@jessegreenberg
Copy link
Contributor Author

Over slack @kathy-phet said

I don't think anything about the ?screens parameter should block MAL publication.

@ariel-phet
Copy link
Contributor

Concurrent top priority with #514 and #515 (particularly since a spot check)

@jessegreenberg might want to consider cherrypicking the fix in: phetsims/joist#645

@jessegreenberg
Copy link
Contributor Author

In phetsims/joist#645 I decided not to cherry-pick changes for that issue because MAL is a single screen sim and does not display the home screen.

@KatieWoe
Copy link
Contributor

KatieWoe commented Aug 4, 2020

QA is done.

@jessegreenberg
Copy link
Contributor Author

OK thank you @KatieWoe and team - we are ready for deploy-production and this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants