Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update credits #341

Closed
jessegreenberg opened this issue May 19, 2020 · 12 comments
Closed

Update credits #341

jessegreenberg opened this issue May 19, 2020 · 12 comments
Assignees

Comments

@jessegreenberg
Copy link
Contributor

From #201, credits should be updated for next publication,

Current list:
Verified additions to Team: Wanda Diaz Merced, Brett Fiedler, Matthew Moore, Taliesin Smith, Brianna Tomlinson, Syan Zhou
Verified Sound Design: Ashton Morris, Mike Winters

Others will be added (like around QA and such). We will modify when we get closer to final publication.

@jessegreenberg
Copy link
Contributor Author

It is time for this. @KatieWoe @terracoda are there any other names to add to the list?

@KatieWoe
Copy link
Contributor

QA: Liam Mulhall, Kathryn Woessner, Logan Bray, Jaspe Arias
These should be in alphabetical order (I was just going down the matrix).

@terracoda
Copy link

The a11y list is good, @jessegreenberg.

@KatieWoe
Copy link
Contributor

QA still needs to be done for phetsims/qa#520 @jessegreenberg

@jessegreenberg
Copy link
Contributor Author

Thanks @KatieWoe - now that phetsims/qa#520 is done can you comment on any names that should be added?

@KatieWoe
Copy link
Contributor

KatieWoe commented Aug 4, 2020

Just the ones in #341 (comment)

jessegreenberg added a commit that referenced this issue Aug 10, 2020
jessegreenberg added a commit that referenced this issue Aug 10, 2020
@jessegreenberg
Copy link
Contributor Author

Credits have been updated in both master and the release branch.

@jessegreenberg
Copy link
Contributor Author

Reopening - coming back to this I misread that #341 (comment) meant the list in #341 (comment) rather than the list in the sim. Names in #341 (comment) need to be added and then another maintenance release should go out.

jessegreenberg added a commit that referenced this issue Aug 13, 2020
jessegreenberg added a commit that referenced this issue Aug 13, 2020
@jessegreenberg
Copy link
Contributor Author

jessegreenberg commented Aug 13, 2020

phetsims/chipper#969 is currently still an issue so if I deploy a maintenance release it will remove the images used by the filter page and other things. I need to wait to deploy until that issue is fixed or someone from the website team can help manually put the images up.

But credits have been updated in both master and 1.5 branch.

@mattpen
Copy link

mattpen commented Aug 17, 2020

phetsims/chipper#969 should be fixed now and shouldn't block progress on this issue.

@jessegreenberg
Copy link
Contributor Author

Thanks @mattpen - and it looks like the fix was made to perennial so no changes will need to be moved to the MAL 1.5 release branch. I am going to go ahead with deploying the next maintenance release of MAL.

@jessegreenberg
Copy link
Contributor Author

1.5.2 was deployed with updates to credits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants