-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xhtml file does not support zoom #363
Comments
Seems to happen on Chrome and Windows as well. |
Interesting, thanks. Zoom works correctly when using mouse/wheel. And command + +/- works if focus is within the simulation. But if there is no focus then it doesn't work. |
In HTML, this fires: In the XHTML document.activeElement is the |
Changing KeyStateTracker to attach listeners to window instead of body seems to fix things and still work in the HTML, but I don't understand why it isn't working in the HTML in the first place. I might end up doing this, but want to think about it a little more. |
It looks like listeners attached to the |
@KatieWoe can you please confirm this is fixed in https://phet-dev.colorado.edu/html/molecules-and-light/1.6.0-dev.1/phet/xhtml/molecules-and-light_all.xhtml? If so I will merge change with release branch. |
Looks good on Win 10 Chrome and Mac 10.15 Safari |
Great, thanks @KatieWoe |
cherry-pick complete, dependencies updated in e39683f |
This is working in phetsims/qa#520 on ChromeOS. Closing |
Test device
Dirac
Operating System
MacOS 10.12.6
Browser
Safari 12.1.2
Problem description
For phetsims/qa#513
Zooming doesn't seem to work on the xhtml file in safari. Tried using the command++/-. The sim would twitch, but not zoom in at all.
The text was updated successfully, but these errors were encountered: