Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commits with ... (introduced by GH) in summary cannot be loaded back in Pharo #11226

Closed
Ducasse opened this issue May 12, 2022 · 3 comments · Fixed by #11305
Closed

Commits with ... (introduced by GH) in summary cannot be loaded back in Pharo #11226

Ducasse opened this issue May 12, 2022 · 3 comments · Fixed by #11305

Comments

@Ducasse
Copy link
Member

Ducasse commented May 12, 2022

When the first line of a commit is too long, GH cuts it and place a ... instead.
This breaks the loading of the code

I do not know if this changes is correct.
Changed

print: (((aVersionInfo perform: sel) ifNil: ['']) asString encodeWith: #'latin-1' ) asString; space ].

into

print: (((aVersionInfo perform: sel) ifNil: ['']) asString encodeWith: #utf8 ) asString; space ].
writeVersionInfo: aVersionInfo
	(self isWritten: aVersionInfo)
		ifTrue: [^ stream nextPutAll: '(id '; print: aVersionInfo id asString; nextPut: $) ].
	stream nextPut: $(.
	#(name message id date time author) do: [:sel | 
		stream 
			nextPutAll: sel; space;
			print: (((aVersionInfo perform: sel) ifNil: ['']) asString encodeWith: #utf8 ) asString; space ].
	stream nextPutAll: 'ancestors ('.
	aVersionInfo ancestors do: [:ea | self writeVersionInfo: ea].
	stream nextPutAll: ') stepChildren ('.
	aVersionInfo stepChildren do: [:ea | self writeVersionInfo: ea].
	stream nextPutAll: '))'.
	
	self wrote: aVersionInfo
@MarcusDenker
Copy link
Member

There is an issue tracker entry

[Iceberg] commit message is not encoded as UTF8 #10781

I think this is related.

@MarcusDenker
Copy link
Member

I just saw that with another repository. With the fix I could load it

@MarcusDenker
Copy link
Member

PRs merged for Pharo10 and Pharo11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants