[Iceberg] commit message is not encoded as UTF8 (again)

[mumez]

Bug description
Commit messages is not encoded as UTF8.
It was reported as #10781 and it was supposed to be fixed by #11226. But the bug was still not fixed.

To Reproduce

1. From the Iceberg commit window, enter some multibyte string and push 'Commit' button
   (If you hard to enter multibyte string, plese print it the result of ZnUTF8Encoder new decodeBytes: (ByteArray readHexFrom: 'e38182e38184e38186'. This code produces the string 'あいう')`).
   

2. Check the commit message by opening repository browser. (Or you can git log from the terminal).

3. You will see the wrongly encoded commit message.

Expected behavior
Commit message is set correctly, You can read the commit log from Iceberg and terminal.

Screenshots

Entering a commit message from Pharo

Git log shows corrupt commit message

Pharo git repository browser also shows corrupt commit message

Version information:

• OS: all
• Pharo Version 11,10, 9

[mumez]

Please reconsider applying the patch I have attached to #10781.
Our team (Allstocker) has been using this trivial patch for years.
It just removes an unnecessary #utf8Encoded message sending in IceGitIndex>>commitWithMessage:andParents:.

[mumez]

After the patch

Entering a commit message from Pharo

Git log shows commit message properly

(raw bytes)

'あいう' should be utf8 encoded as %E3%81%82%E3%81%84%E3%81%86, so it is correct.
https://mothereff.in/utf-8#%E3%81%82%E3%81%84%E3%81%86

UTF-8 encoder/decoder

An online, on-the-fly UTF-8 encoder/decoder.

[guillep]

Hi @mumez, It's great you have a patch!

Would you please consider making a pull request here? https://github.com/pharo-vcs/iceberg
Also, we have many tests for commits in the Iceberg repository, and there should be a place to improve the test suite with a case for this.

GitHub

GitHub - pharo-vcs/iceberg: Iceberg is the main toolset for handling VCS in Pharo.

Iceberg is the main toolset for handling VCS in Pharo. - GitHub - pharo-vcs/iceberg: Iceberg is the main toolset for handling VCS in Pharo.

[mumez]

I sent a PR: pharo-vcs/iceberg#1705
I hope this helps!