Fix pex resolving for foreign platforms. #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjyw
approved these changes
Dec 27, 2019
This pulls in improved support for foreign download targets.
This change restores manylinux handling to the pre pex 2.0.0 status quo while properly supporting manylinux-next via the new `--manylinux` option that takes a manylinux platform upper bound to assume whenever the user specified platform is linux. This upper bound now defaults to manylinux2014. The change also brings in a pip fix for abi3 handling for foreign platforms and a test is added to track this continues to work. Fixes pex-tool#823
Ensure the platforms used are always foreign.
Eliminate encode_identity by inlining where its used. This keeps the symmetry of encode/decode local within a few lines of each other in the same function.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change restores manylinux handling to the pre pex 2.0.0 status quo
while properly supporting manylinux-next via the new
--manylinuxoption that takes a manylinux platform upper bound to assume whenever
the user specified platform is linux. This upper bound now defaults to
manylinux2014.
The change also brings in a pip fix for abi3 handling for foreign
platforms and a test is added to track this continues to work.
Fixes #823