Support VCS urls for vendoring. #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsirois
commented
Dec 26, 2019
| yield VendorSpec.create('wheel==0.33.6') | ||
|
|
||
|
|
||
| def _vendored_dists(distributions): |
There was a problem hiding this comment.
N.B.: setup_interpreter and its helper _vendored_dists needed the removed VendorSpec.version property but were unused.
This will support using a patched version of pip pending acceptance of patches upstream. Work towards pex-tool#823.
jsirois
force-pushed
the
vendor/support_vcs
branch
from
03c2d21
to
626093a
Compare
benjyw
approved these changes
Dec 27, 2019
Eric-Arellano
approved these changes
Dec 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will support using a patched version of pip pending acceptance
of patches upstream.
Work towards #823.