Use pypa/packaging. #831
Merged
Use pypa/packaging. #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reviewers, note that 64c0ad8 is the vendoring commit. The only manual edits there are two small ones to |
jsirois
requested review from
Eric-Arellano,
cosmicexplorer,
kwlzn and
benjyw
benjyw
approved these changes
Dec 27, 2019
Eric-Arellano
approved these changes
Dec 27, 2019
Vendoring pypa/packaging allows us to eliminate our copies of `pep425tags.py` and `glibc.py` from pip as well as eliminate custom environment marker setup code. We accomplish the latter by re-working the responsibility split between `PythonIdentity` and `Platform`. `Platform` now just handles parsing extended platform specifiers and all capability testing is moved into `PythonIdentity` which consults `packaging` at runtime to determine the compatible tag set and appropriate environment markers. Work towards pex-tool#823 Fixes pex-tool#696
jsirois
force-pushed
the
pep425tags/kill
branch
from
05cd11a
to
150f9a9
Compare
jsirois
added a commit
to jsirois/pex
that referenced
this pull request
Dec 28, 2019
Eliminate encode_identity by inlining where its used. This keeps the symmetry of encode/decode local within a few lines of each other in the same function.
jsirois
added a commit
to jsirois/pex
that referenced
this pull request
Jan 23, 2020
The last use was deleted in pex-tool#831 and not removing the file then was an oversight.
jsirois
added a commit
that referenced
this pull request
Jan 24, 2020
The last use was deleted in #831 and not removing the file then was an oversight.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vendoring pypa/packaging allows us to eliminate our copies of
pep425tags.pyandglibc.pyfrom pip as well as eliminate customenvironment marker setup code. We accomplish the latter by re-working
the responsibility split between
PythonIdentityandPlatform.Platformnow just handles parsing extended platform specifiers andall capability testing is moved into
PythonIdentitywhich consultspackagingat runtime to determine the compatible tag set andappropriate environment markers.
Work towards #823
Fixes #696